Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: pkg/front_end/lib/src/fasta/testing/kernel_chain.dart

Issue 2691613002: Improve compile-time error handling. (Closed)
Patch Set: Update status and expectations for rasta tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/testing/kernel_chain.dart
diff --git a/pkg/front_end/lib/src/fasta/testing/kernel_chain.dart b/pkg/front_end/lib/src/fasta/testing/kernel_chain.dart
index 296a79adc2ae3722c152769174e0a8b965318dd2..f987e096fee45b9543377e3be5b418f04e29203d 100644
--- a/pkg/front_end/lib/src/fasta/testing/kernel_chain.dart
+++ b/pkg/front_end/lib/src/fasta/testing/kernel_chain.dart
@@ -155,7 +155,7 @@ abstract class TestContext extends ChainContext {
Uri vm = computeDartVm(sdk);
Uri packages = Uri.base.resolve(".packages");
bool strongMode = false;
- bool updateExpectations = environment["updateExpectations"] != "false";
+ bool updateExpectations = environment["updateExpectations"] == "true";
return constructor(suite, environment, sdk, vm, packages, strongMode,
createDartSdk(sdk.toFilePath(), strongMode: strongMode),
updateExpectations);
@@ -232,7 +232,7 @@ class MatchExpectation extends Step<Program, Program, dynamic> {
// name.
final bool updateExpectations;
- const MatchExpectation(this.suffix, {this.updateExpectations: true});
+ const MatchExpectation(this.suffix, {this.updateExpectations: false});
String get name => "match expectations";
@@ -243,12 +243,6 @@ class MatchExpectation extends Step<Program, Program, dynamic> {
StringBuffer buffer = new StringBuffer();
new Printer(buffer).writeLibraryFile(library);
- bool updateExpectations = this.updateExpectations;
- if (uri.path.contains("/test/fasta/rasta/")) {
- // TODO(ahe): Remove this. Short term, we don't want to automatically
- // update rasta expectations, as we have too many failures.
- updateExpectations = false;
- }
File expectedFile = new File("${uri.toFilePath()}$suffix");
if (await expectedFile.exists()) {
String expected = await expectedFile.readAsString();

Powered by Google App Engine
This is Rietveld 408576698