Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Issue 2685213003: Don't return values that aren't used. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -29 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 8 chunks +12 lines, -15 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 3 chunks +6 lines, -12 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (5 generated)
ahe
3 years, 10 months ago (2017-02-10 16:13:39 UTC) #5
Johnni Winther
lgtm
3 years, 10 months ago (2017-02-13 08:42:42 UTC) #6
ahe
3 years, 10 months ago (2017-02-13 11:37:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:60001) manually as
b92ef72c8e8c60e5eb914a02a49a61cbfa98962a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698