Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: pkg/front_end/lib/src/fasta/builder/library_builder.dart

Issue 2691613002: Improve compile-time error handling. (Closed)
Patch Set: Update status and expectations for rasta tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/builder/library_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/builder/library_builder.dart b/pkg/front_end/lib/src/fasta/builder/library_builder.dart
index 16e6b43ba27ea5dc85ebf60ce8399734426fa94f..2fb52ae277ad3faaaa1211e1be93830799927246 100644
--- a/pkg/front_end/lib/src/fasta/builder/library_builder.dart
+++ b/pkg/front_end/lib/src/fasta/builder/library_builder.dart
@@ -47,15 +47,16 @@ abstract class LibraryBuilder<T extends TypeBuilder, R> extends Builder {
LibraryBuilder(Uri fileUri)
: super(null, -1, fileUri);
- Builder addBuilder(String name, Builder builder);
+ Builder addBuilder(String name, Builder builder, int charOffset);
void addExporter(LibraryBuilder exporter, List<Combinator> combinators,
int charOffset) {
exporters.add(new Export(exporter, this, combinators, charOffset));
}
- void addCompileTimeError(int charOffset, Object message) {
- InputError error = new InputError(uri, charOffset, message);
+ void addCompileTimeError(int charOffset, Object message, [Uri fileUri]) {
+ fileUri ??= this.fileUri;
+ InputError error = new InputError(fileUri, charOffset, message);
compileTimeErrors.add(error);
print(error.format());
}
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart » ('j') | pkg/front_end/lib/src/fasta/errors.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698