Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart

Issue 2691613002: Improve compile-time error handling. (Closed)
Patch Set: Update status and expectations for rasta tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
index 61afab392b395bf728c52cf6a8bc93a0b150f650..1f5b76bebc0b05a5bbfa0b4c93cd7b425a78cf9e 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
@@ -108,7 +108,7 @@ class KernelLibraryBuilder
});
// Nested declaration began in `OutlineBuilder.beginClassDeclaration`.
endNestedDeclaration();
- addBuilder(className, cls);
+ addBuilder(className, cls, charOffset);
}
void addNamedMixinApplication(
@@ -122,13 +122,13 @@ class KernelLibraryBuilder
charOffset);
// Nested declaration began in `OutlineBuilder.beginNamedMixinApplication`.
endNestedDeclaration();
- addBuilder(name, builder);
+ addBuilder(name, builder, charOffset);
}
void addField(List<MetadataBuilder> metadata,
int modifiers, KernelTypeBuilder type, String name, int charOffset) {
addBuilder(name, new KernelFieldBuilder(
- metadata, type, name, modifiers, this, charOffset));
+ metadata, type, name, modifiers, this, charOffset), charOffset);
}
void addProcedure(List<MetadataBuilder> metadata,
@@ -141,7 +141,8 @@ class KernelLibraryBuilder
endNestedDeclaration().resolveTypes(typeVariables);
addBuilder(name,
new KernelProcedureBuilder(metadata, modifiers, returnType, name,
- typeVariables, formals, asyncModifier, kind, this, charOffset));
+ typeVariables, formals, asyncModifier, kind, this, charOffset),
+ charOffset);
}
void addFactoryMethod(List<MetadataBuilder> metadata,
@@ -153,13 +154,14 @@ class KernelLibraryBuilder
addBuilder(name,
new KernelProcedureBuilder(metadata, staticMask, null, name, null,
formals, asyncModifier, ProcedureKind.Factory, this, charOffset,
- redirectionTarget));
+ redirectionTarget), charOffset);
}
void addEnum(List<MetadataBuilder> metadata, String name,
List<String> constants, int charOffset) {
addBuilder(name,
- new KernelEnumBuilder(metadata, name, constants, this, charOffset));
+ new KernelEnumBuilder(metadata, name, constants, this, charOffset),
+ charOffset);
}
void addFunctionTypeAlias(List<MetadataBuilder> metadata,
@@ -171,7 +173,7 @@ class KernelLibraryBuilder
this, charOffset);
// Nested declaration began in `OutlineBuilder.beginFunctionTypeAlias`.
endNestedDeclaration();
- addBuilder(name, typedef);
+ addBuilder(name, typedef, charOffset);
}
KernelFormalParameterBuilder addFormalParameter(

Powered by Google App Engine
This is Rietveld 408576698