DescriptionFix orthogonal mode legacy mismatch
Orthogonal styles currently assert inside legacy layout, because width is -1.
Ex:
<div style="writing-mode:vertical-rl; border:1px solid red;">
<p style="writing-mode:horizontal-tb; border:1px solid blue;">Hello, world.</p>
</div>
These two routines did not handle orthogonal modes properly.
NGConstraintSpace::CreateFromLayoutObject
NGBlockNode::RunOldLayout
I am not sure if this fix is correct, it is my best guess. With the fix, assert
is avoided, but <p> is too tall. The constraint space used for layout looks correct,
bug might be something else.
Meta question: Should we bother with legacy orthogonal modes at all?
I've stumbled upon several other orthogonal mode bugs.
BUG=635619
[ng_orthogonal_legacy]
Review-Url: https://codereview.chromium.org/2691093004
Cr-Commit-Position: refs/heads/master@{#450878}
Committed: https://chromium.googlesource.com/chromium/src/+/283cef0d240cf6a118f605d396eee0fbee0278b7
Patch Set 1 #
Total comments: 16
Patch Set 2 : CR fixes #
Total comments: 2
Patch Set 3 : CR fixes, removed odd IsParallelWritingMode #
Messages
Total messages: 21 (10 generated)
|