third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc - Issue 2691093004: Fix orthogonal mode legacy mismatch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc

Issue 2691093004: Fix orthogonal mode legacy mismatch (Closed)

Patch Set: CR fixes, removed odd IsParallelWritingMode Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_writing_mode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc

index f5e88ddf7b4fbd07c7a96f235803aa67ce416192..3fafff05294a22c166bfb946610dfc71e698c024 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc

@@ -121,8 +121,8 @@ NGConstraintSpace* NGConstraintSpaceBuilder::ToConstraintSpace(

NGWritingMode out_writing_mode) {

// Whether the child and the containing block are parallel to each other.

// Example: vertical-rl and vertical-lr

- bool is_in_parallel_flow = (parent_writing_mode_ == kHorizontalTopBottom) ==

- (out_writing_mode == kHorizontalTopBottom);

+ bool is_in_parallel_flow = IsParallelWritingMode(

+ static_cast<NGWritingMode>(parent_writing_mode_), out_writing_mode);

NGLogicalSize available_size = available_size_;

NGLogicalSize percentage_resolution_size = percentage_resolution_size_;