Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_writing_mode.cc

Issue 2691093004: Fix orthogonal mode legacy mismatch (Closed)
Patch Set: CR fixes, removed odd IsParallelWritingMode Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_writing_mode.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/layout/ng/ng_writing_mode.h" 5 #include "core/layout/ng/ng_writing_mode.h"
6 6
7 #include "core/layout/LayoutObject.h"
7 #include "wtf/Assertions.h" 8 #include "wtf/Assertions.h"
8 9
9 namespace blink { 10 namespace blink {
10 11
11 NGWritingMode FromPlatformWritingMode(WritingMode mode) { 12 NGWritingMode FromPlatformWritingMode(WritingMode mode) {
12 switch (mode) { 13 switch (mode) {
13 case WritingMode::kHorizontalTb: 14 case WritingMode::kHorizontalTb:
14 return kHorizontalTopBottom; 15 return kHorizontalTopBottom;
15 case WritingMode::kVerticalRl: 16 case WritingMode::kVerticalRl:
16 return kVerticalRightLeft; 17 return kVerticalRightLeft;
17 case WritingMode::kVerticalLr: 18 case WritingMode::kVerticalLr:
18 return kVerticalLeftRight; 19 return kVerticalLeftRight;
19 default: 20 default:
20 NOTREACHED(); 21 NOTREACHED();
21 return kHorizontalTopBottom; 22 return kHorizontalTopBottom;
22 } 23 }
23 } 24 }
24 25
26 bool IsParallelWritingMode(NGWritingMode a, NGWritingMode b) {
27 return (a == kHorizontalTopBottom) == (b == kHorizontalTopBottom);
28 }
29
25 } // namespace blink 30 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_writing_mode.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698