Fix orthogonal mode legacy mismatch

third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/ng/ng_constraint_space.h"
 
 #include "core/layout/LayoutBlock.h"
 #include "core/layout/LayoutView.h"
 #include "core/layout/ng/ng_constraint_space_builder.h"
 #include "core/layout/ng/ng_layout_opportunity_iterator.h"
@@ skipping 31 matching lines @@
       block_direction_fragmentation_type_(block_direction_fragmentation_type),
       is_new_fc_(is_new_fc),
       writing_mode_(writing_mode),
       direction_(static_cast<unsigned>(direction)),
       margin_strut_(margin_strut),
       bfc_offset_(bfc_offset),
       exclusions_(exclusions) {}
 
 NGConstraintSpace* NGConstraintSpace::CreateFromLayoutObject(
     const LayoutBox& box) {
+  auto writing_mode = FromPlatformWritingMode(box.styleRef().getWritingMode());
+  bool parallel_containing_block = IsParallelWritingMode(
+      FromPlatformWritingMode(
+          box.containingBlock()->styleRef().getWritingMode()),
+      writing_mode);
   bool fixed_inline = false, fixed_block = false;
-  // XXX for orthogonal writing mode this is not right
-  LayoutUnit available_logical_width =
-      std::max(LayoutUnit(), box.containingBlockLogicalWidthForContent());
+
+  LayoutUnit available_logical_width;
+  if (parallel_containing_block)
+    available_logical_width = box.containingBlockLogicalWidthForContent();
+  else
+    available_logical_width = box.perpendicularContainingBlockLogicalHeight();
+  available_logical_width = std::max(LayoutUnit(), available_logical_width);
+
   LayoutUnit available_logical_height;
   if (!box.parent()) {
     available_logical_height = box.view()->viewLogicalHeightForPercentages();
   } else if (box.containingBlock()) {
-    available_logical_height =
-        box.containingBlock()->availableLogicalHeightForPercentageComputation();
+    if (parallel_containing_block) {
+      available_logical_height =
+          box.containingBlock()
+              ->availableLogicalHeightForPercentageComputation();
+    } else {
+      available_logical_height = box.containingBlockLogicalWidthForContent();
+    }
   }
   NGLogicalSize percentage_size = {available_logical_width,
                                    available_logical_height};
   NGLogicalSize available_size = percentage_size;
   // When we have an override size, the available_logical_{width,height} will be
   // used as the final size of the box, so it has to include border and
   // padding.
   if (box.hasOverrideLogicalContentWidth()) {
     available_size.inline_size =
         box.borderAndPaddingLogicalWidth() + box.overrideLogicalContentWidth();
     fixed_inline = true;
   }
   if (box.hasOverrideLogicalContentHeight()) {
     available_size.block_size = box.borderAndPaddingLogicalHeight() +
                                 box.overrideLogicalContentHeight();
     fixed_block = true;
   }
 
   bool is_new_fc =
       box.isLayoutBlock() && toLayoutBlock(box).createsNewFormattingContext();
 
-  auto writing_mode = FromPlatformWritingMode(box.styleRef().getWritingMode());
-
   FloatSize icb_float_size = box.view()->viewportSizeForViewportUnits();
   NGPhysicalSize initial_containing_block_size{
       LayoutUnit(icb_float_size.width()), LayoutUnit(icb_float_size.height())};
 
   return NGConstraintSpaceBuilder(writing_mode)
       .SetAvailableSize(available_size)
       .SetPercentageResolutionSize(percentage_size)
       .SetInitialContainingBlockSize(initial_containing_block_size)
       .SetIsInlineDirectionTriggersScrollbar(
           box.styleRef().overflowInlineDirection() == EOverflow::kAuto)
@@ skipping 23 matching lines @@
 String NGConstraintSpace::ToString() const {
   return String::format("Offset: %s,%s Size: %sx%s MarginStrut: %s",
                         bfc_offset_.inline_offset.toString().ascii().data(),
                         bfc_offset_.block_offset.toString().ascii().data(),
                         AvailableSize().inline_size.toString().ascii().data(),
                         AvailableSize().block_size.toString().ascii().data(),
                         margin_strut_.ToString().ascii().data());
 }
 
 }  // namespace blink