Revert "Updated ownership of NavigationItems within CRWSessionController."

Revert "Updated ownership of NavigationItems within CRWSessionController."

The original CL updated behavior in a couple ways that were introducing many bugs:
- New CRWSessionEntries were vended every time a session entry property was
  accessed, which which broke logic comparing CRWSessionEntries.
- CRWSessionEntries held an unowned pointer to their corresponding
  NavigationItems, making it possible for the CRWSessionEntry to outlive its backing
  NavigationItem.

The CL will be re-landed once callers have been updated to reflect this new
behavior.


This reverts 3 CLs:
https://codereview.chromium.org/2672953005 (original CL)
https://codereview.chromium.org/2690973002 (hacky fix)
https://codereview.chromium.org/2680313004 (hacky fix)

BUG=689358, 691634, 545227, 691492, 691469
Review-Url: https://codereview.chromium.org/2690913003
Cr-Commit-Position: refs/heads/master@{#450156}
Committed: https://chromium.googlesource.com/chromium/src/+/2b55257be75ef0790299a2a239fbb8d33ec4e805

[kkhorimoto, 2017-02-13 19:49:06]

The CQ bit was checked by kkhorimoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 19:50:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 20:00:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 20:00:26]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[kkhorimoto, 2017-02-13 21:06:53]

The CQ bit was checked by kkhorimoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-13 21:08:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kkhorimoto, 2017-02-13 22:31:48]

Description was changed from

==========
Revert "Updated ownership of NavigationItems within CRWSessionController."

This reverts commit 6e8bfa3991a15be001ac300469bc5e7c49e34d57.

BUG=
==========

to

==========
Revert "Updated ownership of NavigationItems within CRWSessionController."

This reverts 3 CLs:
https://codereview.chromium.org/2672953005 (original CL)
https://codereview.chromium.org/2690973002 (hacky fix)
https://codereview.chromium.org/2680313004 (hacky fix)

BUG=
==========

[kkhorimoto, 2017-02-13 22:40:36]

Description was changed from

==========
Revert "Updated ownership of NavigationItems within CRWSessionController."

This reverts 3 CLs:
https://codereview.chromium.org/2672953005 (original CL)
https://codereview.chromium.org/2690973002 (hacky fix)
https://codereview.chromium.org/2680313004 (hacky fix)

BUG=
==========

to

==========
Revert "Updated ownership of NavigationItems within CRWSessionController."

The original CL updated behavior in a couple ways that were introducing many
bugs:
- New CRWSessionEntries were vended every time a session entry property was
  accessed, which which broke logic comparing CRWSessionEntries.
- CRWSessionEntries held an unowned pointer to their corresponding
  NavigationItems, making it possible for the CRWSessionEntry to outlive its
backing
  NavigationItem.

The CL will be re-landed once callers have been updated to reflect this new
behavior.


This reverts 3 CLs:
https://codereview.chromium.org/2672953005 (original CL)
https://codereview.chromium.org/2690973002 (hacky fix)
https://codereview.chromium.org/2680313004 (hacky fix)

BUG=
==========

[kkhorimoto, 2017-02-13 22:41:19]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org

[kkhorimoto, 2017-02-13 22:41:20]

I'm testing whether this definitively fixes all the bugs reported this morning;
will update the BUG= line and land in a bit.

[kkhorimoto, 2017-02-13 23:11:07]

Description was changed from

==========
Revert "Updated ownership of NavigationItems within CRWSessionController."

The original CL updated behavior in a couple ways that were introducing many
bugs:
- New CRWSessionEntries were vended every time a session entry property was
  accessed, which which broke logic comparing CRWSessionEntries.
- CRWSessionEntries held an unowned pointer to their corresponding
  NavigationItems, making it possible for the CRWSessionEntry to outlive its
backing
  NavigationItem.

The CL will be re-landed once callers have been updated to reflect this new
behavior.


This reverts 3 CLs:
https://codereview.chromium.org/2672953005 (original CL)
https://codereview.chromium.org/2690973002 (hacky fix)
https://codereview.chromium.org/2680313004 (hacky fix)

BUG=
==========

to

==========
Revert "Updated ownership of NavigationItems within CRWSessionController."

The original CL updated behavior in a couple ways that were introducing many
bugs:
- New CRWSessionEntries were vended every time a session entry property was
  accessed, which which broke logic comparing CRWSessionEntries.
- CRWSessionEntries held an unowned pointer to their corresponding
  NavigationItems, making it possible for the CRWSessionEntry to outlive its
backing
  NavigationItem.

The CL will be re-landed once callers have been updated to reflect this new
behavior.


This reverts 3 CLs:
https://codereview.chromium.org/2672953005 (original CL)
https://codereview.chromium.org/2690973002 (hacky fix)
https://codereview.chromium.org/2680313004 (hacky fix)

BUG=689358, 691634, 545227, 691492, 691469
==========

[kkhorimoto, 2017-02-13 23:11:25]

Description was changed from

==========
Revert "Updated ownership of NavigationItems within CRWSessionController."

The original CL updated behavior in a couple ways that were introducing many
bugs:
- New CRWSessionEntries were vended every time a session entry property was
  accessed, which which broke logic comparing CRWSessionEntries.
- CRWSessionEntries held an unowned pointer to their corresponding
  NavigationItems, making it possible for the CRWSessionEntry to outlive its
backing
  NavigationItem.

The CL will be re-landed once callers have been updated to reflect this new
behavior.


This reverts 3 CLs:
https://codereview.chromium.org/2672953005 (original CL)
https://codereview.chromium.org/2690973002 (hacky fix)
https://codereview.chromium.org/2680313004 (hacky fix)

BUG=689358, 691634, 545227, 691492, 691469
==========

to

==========
Revert "Updated ownership of NavigationItems within CRWSessionController."

The original CL updated behavior in a couple ways that were introducing many
bugs:
- New CRWSessionEntries were vended every time a session entry property was
  accessed, which which broke logic comparing CRWSessionEntries.
- CRWSessionEntries held an unowned pointer to their corresponding
  NavigationItems, making it possible for the CRWSessionEntry to outlive its
backing
  NavigationItem.

The CL will be re-landed once callers have been updated to reflect this new
behavior.


This reverts 3 CLs:
https://codereview.chromium.org/2672953005 (original CL)
https://codereview.chromium.org/2690973002 (hacky fix)
https://codereview.chromium.org/2680313004 (hacky fix)

BUG=689358, 691634, 545227, 691492, 691469
TBR=eugenebut@chromium.org
==========

[Eugene But (OOO till 7-30), 2017-02-13 23:12:24]

lgtm

[kkhorimoto, 2017-02-13 23:16:25]

Description was changed from

==========
Revert "Updated ownership of NavigationItems within CRWSessionController."

The original CL updated behavior in a couple ways that were introducing many
bugs:
- New CRWSessionEntries were vended every time a session entry property was
  accessed, which which broke logic comparing CRWSessionEntries.
- CRWSessionEntries held an unowned pointer to their corresponding
  NavigationItems, making it possible for the CRWSessionEntry to outlive its
backing
  NavigationItem.

The CL will be re-landed once callers have been updated to reflect this new
behavior.


This reverts 3 CLs:
https://codereview.chromium.org/2672953005 (original CL)
https://codereview.chromium.org/2690973002 (hacky fix)
https://codereview.chromium.org/2680313004 (hacky fix)

BUG=689358, 691634, 545227, 691492, 691469
TBR=eugenebut@chromium.org
==========

to

==========
Revert "Updated ownership of NavigationItems within CRWSessionController."

The original CL updated behavior in a couple ways that were introducing many
bugs:
- New CRWSessionEntries were vended every time a session entry property was
  accessed, which which broke logic comparing CRWSessionEntries.
- CRWSessionEntries held an unowned pointer to their corresponding
  NavigationItems, making it possible for the CRWSessionEntry to outlive its
backing
  NavigationItem.

The CL will be re-landed once callers have been updated to reflect this new
behavior.


This reverts 3 CLs:
https://codereview.chromium.org/2672953005 (original CL)
https://codereview.chromium.org/2690973002 (hacky fix)
https://codereview.chromium.org/2680313004 (hacky fix)

BUG=689358, 691634, 545227, 691492, 691469
==========

[commit-bot: I haz the power, 2017-02-13 23:43:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 23:43:02]

Dry run: This issue passed the CQ dry run.

[kkhorimoto, 2017-02-13 23:44:32]

The CQ bit was checked by kkhorimoto@chromium.org

[commit-bot: I haz the power, 2017-02-13 23:45:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 23:52:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487029472109720,
"parent_rev": "5a9fe272cb758a4a60f251bd797144fa7c75e79f", "commit_rev":
"2b55257be75ef0790299a2a239fbb8d33ec4e805"}

[commit-bot: I haz the power, 2017-02-13 23:53:16]

Description was changed from

==========
Revert "Updated ownership of NavigationItems within CRWSessionController."

The original CL updated behavior in a couple ways that were introducing many
bugs:
- New CRWSessionEntries were vended every time a session entry property was
  accessed, which which broke logic comparing CRWSessionEntries.
- CRWSessionEntries held an unowned pointer to their corresponding
  NavigationItems, making it possible for the CRWSessionEntry to outlive its
backing
  NavigationItem.

The CL will be re-landed once callers have been updated to reflect this new
behavior.


This reverts 3 CLs:
https://codereview.chromium.org/2672953005 (original CL)
https://codereview.chromium.org/2690973002 (hacky fix)
https://codereview.chromium.org/2680313004 (hacky fix)

BUG=689358, 691634, 545227, 691492, 691469
==========

to

==========
Revert "Updated ownership of NavigationItems within CRWSessionController."

The original CL updated behavior in a couple ways that were introducing many
bugs:
- New CRWSessionEntries were vended every time a session entry property was
  accessed, which which broke logic comparing CRWSessionEntries.
- CRWSessionEntries held an unowned pointer to their corresponding
  NavigationItems, making it possible for the CRWSessionEntry to outlive its
backing
  NavigationItem.

The CL will be re-landed once callers have been updated to reflect this new
behavior.


This reverts 3 CLs:
https://codereview.chromium.org/2672953005 (original CL)
https://codereview.chromium.org/2690973002 (hacky fix)
https://codereview.chromium.org/2680313004 (hacky fix)

BUG=689358, 691634, 545227, 691492, 691469

Review-Url: https://codereview.chromium.org/2690913003
Cr-Commit-Position: refs/heads/master@{#450156}
Committed:
https://chromium.googlesource.com/chromium/src/+/2b55257be75ef0790299a2a239fb...
==========

[commit-bot: I haz the power, 2017-02-13 23:53:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2b55257be75ef0790299a2a239fb...