Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2690973002: Add CRWSessionEntry isEqual (Closed)

Created:
3 years, 10 months ago by Olivier
Modified:
3 years, 10 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CRWSessionEntry isEqual EGTest have DCHECKs on CRWSessionEntry equality (e.g. TabHistoryPopupControllerTestCase testTabHistoryMenu). This fails because entry can be different even if they have the same navigation item. This is a tentative fix by the sheriff to make the tree green. Please review this CL and revert it later if there is a better solution. BUG=691469 Review-Url: https://codereview.chromium.org/2690973002 Cr-Commit-Position: refs/heads/master@{#449923} Committed: https://chromium.googlesource.com/chromium/src/+/b8d957c64f413bde7d4e32bdf375bf622446e7ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ios/web/navigation/crw_session_entry.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
Olivier
3 years, 10 months ago (2017-02-13 08:42:51 UTC) #2
sdefresne
lgtm to fix the tree, but Eugene/Kurt should review this post landing too.
3 years, 10 months ago (2017-02-13 10:12:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690973002/1
3 years, 10 months ago (2017-02-13 10:13:09 UTC) #5
Olivier
On 2017/02/13 10:13:09, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 10 months ago (2017-02-13 10:14:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b8d957c64f413bde7d4e32bdf375bf622446e7ff
3 years, 10 months ago (2017-02-13 10:27:03 UTC) #10
Eugene But (OOO till 7-30)
3 years, 10 months ago (2017-02-13 16:52:38 UTC) #11
Message was sent while issue was closed.
lgtm for fixing the tree. Thank you for doing this.

Powered by Google App Engine
This is Rietveld 408576698