ios/web/navigation/session_storage_builder.mm - Issue 2690913003: Revert "Updated ownership of NavigationItems within CRWSessionController."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/navigation/session_storage_builder.mm

Issue 2690913003: Revert "Updated ownership of NavigationItems within CRWSessionController." (Closed)

Patch Set: Revert olivier's CLs Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/navigation/session_storage_builder.mm

diff --git a/ios/web/navigation/session_storage_builder.mm b/ios/web/navigation/session_storage_builder.mm

index ba44f375e8c9fddfb221cc2b1f14e4af3867bcb3..ca9c3b17a752ea3f31ff7b56e56f8f51175ee2c6 100644

--- a/ios/web/navigation/session_storage_builder.mm

+++ b/ios/web/navigation/session_storage_builder.mm

@@ -59,7 +59,8 @@ @interface CRWSessionController (ExposedForSerialization)

NSMutableArray* item_storages = [[NSMutableArray alloc] init];

NavigationItemStorageBuilder item_storage_builder;

for (size_t index = 0; index < session_controller.items.size(); ++index) {

- web::NavigationItemImpl* item = session_controller.items[index].get();

+ web::NavigationItemImpl* item =

+ static_cast<web::NavigationItemImpl*>(session_controller.items[index]);

[item_storages addObject:item_storage_builder.BuildStorage(item)];

}

serialized_navigation_manager.itemStorages = item_storages;