Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 2680313004: [Reading List] Navigate to the amphtml link in Google SRP AMP pages. (Closed)

Created:
3 years, 10 months ago by Olivier
Modified:
3 years, 10 months ago
Reviewers:
gambard
CC:
chromium-reviews, marq+watch_chromium.org, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reading List] Navigate to the amphtml link in Google SRP AMP pages. Google Search page now gives us the link to the publisher AMP page. Use this link instead of the trick consisting of navigating to the iframe URL. BUG=690021 Review-Url: https://codereview.chromium.org/2680313004 Cr-Commit-Position: refs/heads/master@{#449583} Committed: https://chromium.googlesource.com/chromium/src/+/12a5a4085139903e5fbd11468b8fc77a56e50ad2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M ios/chrome/browser/reading_list/reading_list_distiller_page.mm View 2 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Olivier
3 years, 10 months ago (2017-02-10 09:22:08 UTC) #2
gambard
lgtm
3 years, 10 months ago (2017-02-10 09:31:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2680313004/1
3 years, 10 months ago (2017-02-10 10:16:48 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 10:45:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/12a5a4085139903e5fbd11468b8f...

Powered by Google App Engine
This is Rietveld 408576698