Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2688413003: Extract BackendUsage, MirrorsData, and CheckedModeHelpers from Backend. (Closed)

Created:
3 years, 10 months ago by Johnni Winther
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extract BackendUsage, MirrorsData, and CheckedModeHelpers from Backend. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/ebaff3dc66606f50395e202b66be129c4281e988

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+783 lines, -713 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 25 chunks +44 lines, -600 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A pkg/compiler/lib/src/js_backend/backend_usage.dart View 1 chunk +88 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart View 6 chunks +201 lines, -50 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/mirrors_analysis.dart View 2 chunks +3 lines, -2 lines 0 comments Download
A pkg/compiler/lib/src/js_backend/mirrors_data.dart View 1 chunk +370 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 4 chunks +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 7 chunks +10 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 2 chunks +7 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/metadata_collector.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_generator.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 4 chunks +15 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/type_test_registry.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/mirrors_used.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/deferred_mirrors_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mirror_private_name_inheritance_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mirror_tree_shaking_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 10 months ago (2017-02-13 10:09:08 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-02-14 22:58:08 UTC) #3
Johnni Winther
3 years, 10 months ago (2017-02-20 10:44:23 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ebaff3dc66606f50395e202b66be129c4281e988 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698