Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart

Issue 2688413003: Extract BackendUsage, MirrorsData, and CheckedModeHelpers from Backend. (Closed)
Patch Set: Cleanup Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart
diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart b/pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart
index 2e19299a5fdc8756767dbf95000cc6ae22e76b09..7f1ac60b19c23100be2d9fbee006d608cb6ce678 100644
--- a/pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart
+++ b/pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart
@@ -140,7 +140,7 @@ class FieldVisitor {
bool fieldNeedsGetter(VariableElement field) {
assert(field.isField);
if (fieldAccessNeverThrows(field)) return false;
- if (backend.shouldRetainGetter(field)) return true;
+ if (backend.mirrorsData.shouldRetainGetter(field)) return true;
return field.isClassMember &&
compiler.codegenWorldBuilder.hasInvokedGetter(field, closedWorld);
}
@@ -149,7 +149,7 @@ class FieldVisitor {
assert(field.isField);
if (fieldAccessNeverThrows(field)) return false;
if (field.isFinal || field.isConst) return false;
- if (backend.shouldRetainSetter(field)) return true;
+ if (backend.mirrorsData.shouldRetainSetter(field)) return true;
return field.isClassMember &&
compiler.codegenWorldBuilder.hasInvokedSetter(field, closedWorld);
}

Powered by Google App Engine
This is Rietveld 408576698