pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart - Issue 2688413003: Extract BackendUsage, MirrorsData, and CheckedModeHelpers from Backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

Issue 2688413003: Extract BackendUsage, MirrorsData, and CheckedModeHelpers from Backend. (Closed)

Patch Set: Cleanup Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart ('k') | pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

index 5092d19fb80651906f991223b6deb1825a45094c..6cdc150c839a3fef363dd661943ae666ad3d8c93 100644

--- a/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

+++ b/pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

@@ -543,7 +543,7 @@ class ProgramBuilder {

// If the program contains `const Symbol` names we have to retain them.

String selectorName = selector.name;

if (selector.isSetter) selectorName = "$selectorName=";

- if (backend.symbolsUsed.contains(selectorName)) {

+ if (backend.mirrorsData.symbolsUsed.contains(selectorName)) {

_symbolsMap[name] = selectorName;

}

noSuchMethodStubs.add(

@@ -655,7 +655,7 @@ class ProgramBuilder {

}

bool _methodCanBeReflected(FunctionElement method) {

- return backend.isAccessibleByReflection(method);

+ return backend.mirrorsData.isAccessibleByReflection(method);

}

bool _methodCanBeApplied(FunctionElement method) {