pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart - Issue 2688413003: Extract BackendUsage, MirrorsData, and CheckedModeHelpers from Backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

Issue 2688413003: Extract BackendUsage, MirrorsData, and CheckedModeHelpers from Backend. (Closed)

Patch Set: Cleanup Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart ('k') | pkg/compiler/lib/src/js_emitter/metadata_collector.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

index 402845b41f3be403414b2d30cfd6d0c84a0fb6db..111b1b60327bef6cafeaee0def82106ec85b6c75 100644

--- a/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

@@ -72,7 +72,7 @@ jsAst.Statement buildSetupProgram(Program program, Compiler compiler,

String defaultValuesField = namer.defaultValuesField;

String methodsWithOptionalArgumentsField =

namer.methodsWithOptionalArgumentsField;

- String unmangledNameIndex = backend.mustRetainMetadata

+ String unmangledNameIndex = backend.mirrorsData.mustRetainMetadata

? ' 3 * optionalParameterCount + 2 * requiredParameterCount + 3'

: ' 2 * optionalParameterCount + requiredParameterCount + 3';

String receiverParamName =

@@ -119,7 +119,7 @@ jsAst.Statement buildSetupProgram(Program program, Compiler compiler,

'initializeEmptyInstance': initializeEmptyInstanceAccess,

'allClasses': allClassesAccess,

'debugFastObjects': DEBUG_FAST_OBJECTS,

- 'isTreeShakingDisabled': backend.isTreeShakingDisabled,

+ 'isTreeShakingDisabled': backend.mirrorsData.isTreeShakingDisabled,

'precompiled': precompiledAccess,

'finishedClassesAccess': finishedClassesAccess,

'needsMixinSupport': emitter.needsMixinSupport,

@@ -130,7 +130,7 @@ jsAst.Statement buildSetupProgram(Program program, Compiler compiler,

'isObject': namer.operatorIs(compiler.commonElements.objectClass),

'specProperty': js.string(namer.nativeSpecProperty),

'trivialNsmHandlers': emitter.buildTrivialNsmHandlers(),

- 'hasRetainedMetadata': backend.hasRetainedMetadata,

+ 'hasRetainedMetadata': backend.mirrorsData.hasRetainedMetadata,

'types': typesAccess,

'objectClassName': js.quoteName(

namer.runtimeTypeName(compiler.commonElements.objectClass as Entity)),