Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

Issue 2688413003: Extract BackendUsage, MirrorsData, and CheckedModeHelpers from Backend. (Closed)
Patch Set: Cleanup Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart
index 7f2c08457d9e147c9d47d2914aa0c26cf0d17b54..16e454a4c0f996d5f45564687519df7dc18f29ec 100644
--- a/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart
@@ -447,12 +447,13 @@ class Emitter implements js_emitter.Emitter {
/// This is used by js_mirrors.dart.
String getReflectionName(elementOrSelector, jsAst.Name mangledName) {
String name = elementOrSelector.name;
- if (backend.shouldRetainName(name) ||
+ if (backend.mirrorsData.shouldRetainName(name) ||
elementOrSelector is Element &&
// Make sure to retain names of unnamed constructors, and
// for common native types.
((name == '' &&
- backend.isAccessibleByReflection(elementOrSelector)) ||
+ backend.mirrorsData
+ .isAccessibleByReflection(elementOrSelector)) ||
_isNativeTypeNeedingReflectionName(elementOrSelector))) {
// TODO(ahe): Enable the next line when I can tell the difference between
// an instance method and a global. They may have the same mangled name.
@@ -1039,10 +1040,10 @@ class Emitter implements js_emitter.Emitter {
}
}
- String libraryName =
- (!compiler.options.enableMinification || backend.mustRetainLibraryNames)
- ? library.libraryName
- : "";
+ String libraryName = (!compiler.options.enableMinification ||
+ backend.mirrorsData.mustRetainLibraryNames)
+ ? library.libraryName
+ : "";
jsAst.Fun metadata = task.metadataCollector.buildMetadataFunction(library);

Powered by Google App Engine
This is Rietveld 408576698