Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 268773006: Refactor gles2_cmd_decoder_unittest.cc into components. (Closed)

Created:
6 years, 7 months ago by vmiura
Modified:
6 years, 7 months ago
Reviewers:
zmo, Zhenyao Mo, jbauman, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Refactor gles2_cmd_decoder_unittest.cc into components. gles2_cmd_decoder_unittest.cc has gotten too big and additional work is causing build errors on Win64. See CL https://codereview.chromium.org/262793002/ for example. This change splits up gles2_cmd_decoder_unittest.cc into smaller logical components. BUG=369596 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267951

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10810 lines, -9282 lines) Patch
A gpu/command_buffer/service/gles2_cmd_decoder_unittest.h View 1 chunk +74 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 4 chunks +894 lines, -9282 lines 0 comments Download
A gpu/command_buffer/service/gles2_cmd_decoder_unittest_async_pixel.cc View 1 chunk +390 lines, -0 lines 0 comments Download
A gpu/command_buffer/service/gles2_cmd_decoder_unittest_attribs.cc View 1 chunk +544 lines, -0 lines 0 comments Download
A gpu/command_buffer/service/gles2_cmd_decoder_unittest_context_state.cc View 1 chunk +386 lines, -0 lines 0 comments Download
A gpu/command_buffer/service/gles2_cmd_decoder_unittest_drawing.cc View 1 chunk +2164 lines, -0 lines 0 comments Download
A gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc View 1 chunk +2219 lines, -0 lines 0 comments Download
A gpu/command_buffer/service/gles2_cmd_decoder_unittest_programs.cc View 1 chunk +1391 lines, -0 lines 0 comments Download
A gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc View 1 chunk +2740 lines, -0 lines 0 comments Download
M gpu/gpu.gyp View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
vmiura
PTAL.
6 years, 7 months ago (2014-05-02 19:35:36 UTC) #1
piman
+1, thanks for this! LGTM
6 years, 7 months ago (2014-05-02 19:54:33 UTC) #2
jbauman
lgtm
6 years, 7 months ago (2014-05-02 20:19:23 UTC) #3
Zhenyao Mo
LGTM
6 years, 7 months ago (2014-05-02 20:20:34 UTC) #4
vmiura
The CQ bit was checked by vmiura@chromium.org
6 years, 7 months ago (2014-05-02 20:57:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmiura@chromium.org/268773006/1
6 years, 7 months ago (2014-05-02 20:57:57 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 21:18:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 21:18:40 UTC) #8
vmiura
The CQ bit was checked by vmiura@chromium.org
6 years, 7 months ago (2014-05-02 21:19:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmiura@chromium.org/268773006/1
6 years, 7 months ago (2014-05-02 21:19:59 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 23:04:43 UTC) #11
Message was sent while issue was closed.
Change committed as 267951

Powered by Google App Engine
This is Rietveld 408576698