[Ozone] Adding a software surface implementation

[Ozone] Adding a software surface implementation

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228294

[rjkroege, 2013-10-11 17:26:51]

https://codereview.chromium.org/26866006/diff/1/ui/gfx/ozone/impl/software_su...
File ui/gfx/ozone/impl/software_surface_ozone.cc (right):

https://codereview.chromium.org/26866006/diff/1/ui/gfx/ozone/impl/software_su...
ui/gfx/ozone/impl/software_surface_ozone.cc:47: BufferGeneratorOzone*
buffer_generator)
rather than having a buffer generator class, why not just pass in the bitmap?
that will permit providing a mock for tests?

or just make "CreateBuffer" a virtual method and override it in a test? it's
reasonable to make testing subclasses be friends.

https://codereview.chromium.org/26866006/diff/1/ui/gfx/ozone/impl/software_su...
ui/gfx/ozone/impl/software_surface_ozone.cc:90: front_buffer_ ^= 1;
either the vector is unnecessary or this will be sad in 97 if one bitmap
couldn't be initialized.

https://codereview.chromium.org/26866006/diff/1/ui/gfx/ozone/impl/software_su...
File ui/gfx/ozone/impl/software_surface_ozone.h (right):

https://codereview.chromium.org/26866006/diff/1/ui/gfx/ozone/impl/software_su...
ui/gfx/ozone/impl/software_surface_ozone.h:22: // SoftwareSurfaceOzone is used
to represent a surface that can be scanned out
this is awesome comment

https://codereview.chromium.org/26866006/diff/1/ui/gfx/ozone/impl/software_su...
ui/gfx/ozone/impl/software_surface_ozone.h:41: // controller.Initialize();
your example is missing the call to surface->Initialize. And the arguments to
SoftwareSurfaceOzone.

https://codereview.chromium.org/26866006/diff/1/ui/gfx/ozone/impl/software_su...
ui/gfx/ozone/impl/software_surface_ozone.h:153: ScopedVector<DrmSkBitmapOzone>
bitmaps_;
there are always two? use a fixed size scoped_ptr.

[dnicoara, 2013-10-11 19:20:06]

https://codereview.chromium.org/26866006/diff/1/ui/gfx/ozone/impl/software_su...
File ui/gfx/ozone/impl/software_surface_ozone.cc (right):

https://codereview.chromium.org/26866006/diff/1/ui/gfx/ozone/impl/software_su...
ui/gfx/ozone/impl/software_surface_ozone.cc:47: BufferGeneratorOzone*
buffer_generator)
On 2013/10/11 17:26:51, rjkroege wrote:
> rather than having a buffer generator class, why not just pass in the bitmap?
> that will permit providing a mock for tests?
> 
> or just make "CreateBuffer" a virtual method and override it in a test? it's
> reasonable to make testing subclasses be friends.

Done.

https://codereview.chromium.org/26866006/diff/1/ui/gfx/ozone/impl/software_su...
ui/gfx/ozone/impl/software_surface_ozone.cc:90: front_buffer_ ^= 1;
On 2013/10/11 17:26:51, rjkroege wrote:
> either the vector is unnecessary or this will be sad in 97 if one bitmap
> couldn't be initialized.

Changed how the bitmaps are stored and added CHECK.

https://codereview.chromium.org/26866006/diff/1/ui/gfx/ozone/impl/software_su...
File ui/gfx/ozone/impl/software_surface_ozone.h (right):

https://codereview.chromium.org/26866006/diff/1/ui/gfx/ozone/impl/software_su...
ui/gfx/ozone/impl/software_surface_ozone.h:41: // controller.Initialize();
On 2013/10/11 17:26:51, rjkroege wrote:
> your example is missing the call to surface->Initialize. And the arguments to
> SoftwareSurfaceOzone.
> 
> 
> 

Done.

https://codereview.chromium.org/26866006/diff/1/ui/gfx/ozone/impl/software_su...
ui/gfx/ozone/impl/software_surface_ozone.h:153: ScopedVector<DrmSkBitmapOzone>
bitmaps_;
On 2013/10/11 17:26:51, rjkroege wrote:
> there are always two? use a fixed size scoped_ptr.

Done.

[rjkroege, 2013-10-11 19:53:53]

lgtm

[commit-bot: I haz the power, 2013-10-11 20:34:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dnicoara@chromium.org/26866006/6001

[commit-bot: I haz the power, 2013-10-12 00:52:18]

Change committed as 228294