[ios] Hoists the FindInPageModel up into the controller.

[ios] Hoists the FindInPageModel up into the controller.

BUG=691073
Review-Url: https://codereview.chromium.org/2685393004
Cr-Commit-Position: refs/heads/master@{#450360}
Committed: https://chromium.googlesource.com/chromium/src/+/14d8eadd0f284b639fd64519238ff930e2e1cc10

[rohitrao (ping after 24h), 2017-02-10 20:51:50]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 20:52:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 21:05:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 21:05:30]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2017-02-10 21:05:52]

Description was changed from

==========
[ios] Hoists the FindInPageModel up into the controller.

BUG=None
==========

to

==========
[ios] Hoists the FindInPageModel up into the controller.

BUG=691073
==========

[rohitrao (ping after 24h), 2017-02-10 21:07:07]

rohitrao@chromium.org changed reviewers:
+ justincohen@chromium.org

[rohitrao (ping after 24h), 2017-02-10 21:07:08]

https://codereview.chromium.org/2685393004/diff/1/ios/chrome/browser/find_in_...
File ios/chrome/browser/find_in_page/js_findinpage_manager.h (right):

https://codereview.chromium.org/2685393004/diff/1/ios/chrome/browser/find_in_...
ios/chrome/browser/find_in_page/js_findinpage_manager.h:30: @property(nonatomic,
readwrite, strong) FindInPageModel* findInPageModel;
This isn't created by the manager anymore, but I think it's ok for it to still
be a strong reference?

[justincohen, 2017-02-13 18:09:36]

https://codereview.chromium.org/2685393004/diff/1/ios/chrome/browser/find_in_...
File ios/chrome/browser/find_in_page/find_in_page_controller.mm (right):

https://codereview.chromium.org/2685393004/diff/1/ios/chrome/browser/find_in_...
ios/chrome/browser/find_in_page/find_in_page_controller.mm:111:
_findInPageJsManager.findInPageModel = _findInPageModel;
Does this need to be nilled out on dealloc of fipcontroller?

[rohitrao (ping after 24h), 2017-02-14 14:52:49]

https://codereview.chromium.org/2685393004/diff/1/ios/chrome/browser/find_in_...
File ios/chrome/browser/find_in_page/find_in_page_controller.mm (right):

https://codereview.chromium.org/2685393004/diff/1/ios/chrome/browser/find_in_...
ios/chrome/browser/find_in_page/find_in_page_controller.mm:111:
_findInPageJsManager.findInPageModel = _findInPageModel;
On 2017/02/13 18:09:36, justincohen wrote:
> Does this need to be nilled out on dealloc of fipcontroller?

I made it a strong reference, so the JS manager will keep the object alive as
long as needed.

[rohitrao (ping after 24h), 2017-02-14 14:52:54]

The CQ bit was checked by rohitrao@chromium.org

[commit-bot: I haz the power, 2017-02-14 14:53:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 14:53:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-14 14:53:13]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[justincohen, 2017-02-14 15:03:46]

lgtm

[rohitrao (ping after 24h), 2017-02-14 15:06:22]

The CQ bit was checked by rohitrao@chromium.org

[commit-bot: I haz the power, 2017-02-14 15:06:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 15:35:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487084782825780, "parent_rev":
"ea4e800e0603a0fc1710db7e249a10c7f09a6a76", "commit_rev":
"14d8eadd0f284b639fd64519238ff930e2e1cc10"}

[commit-bot: I haz the power, 2017-02-14 15:36:01]

Description was changed from

==========
[ios] Hoists the FindInPageModel up into the controller.

BUG=691073
==========

to

==========
[ios] Hoists the FindInPageModel up into the controller.

BUG=691073

Review-Url: https://codereview.chromium.org/2685393004
Cr-Commit-Position: refs/heads/master@{#450360}
Committed:
https://chromium.googlesource.com/chromium/src/+/14d8eadd0f284b639fd64519238f...
==========

[commit-bot: I haz the power, 2017-02-14 15:36:03]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/14d8eadd0f284b639fd64519238f...