ios/chrome/browser/find_in_page/js_findinpage_manager.mm - Issue 2685393004: [ios] Hoists the FindInPageModel up into the controller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/find_in_page/js_findinpage_manager.mm

Issue 2685393004: [ios] Hoists the FindInPageModel up into the controller. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/find_in_page/js_findinpage_manager.mm

diff --git a/ios/chrome/browser/find_in_page/js_findinpage_manager.mm b/ios/chrome/browser/find_in_page/js_findinpage_manager.mm

index 96d4b6045168fecb997e3aa89f3f9fdfa063cb82..965073d597ac0c01ad5c416fbe2831ec2a827f7d 100644

--- a/ios/chrome/browser/find_in_page/js_findinpage_manager.mm

+++ b/ios/chrome/browser/find_in_page/js_findinpage_manager.mm

@@ -80,12 +80,6 @@ const FindInPageEntry kFindInPageEntryZero = {{0.0, 0.0}, 0};

@implementation JsFindinpageManager

@synthesize findInPageModel = _findInPageModel;

-- (FindInPageModel*)findInPageModel {

- if (!_findInPageModel)

- _findInPageModel = [[FindInPageModel alloc] init];

- return _findInPageModel;

- (void)setWidth:(CGFloat)width height:(CGFloat)height {

NSString* javaScript =

[NSString stringWithFormat:kFindInPageInit, width, height];