ios/chrome/browser/find_in_page/js_findinpage_manager.h - Issue 2685393004: [ios] Hoists the FindInPageModel up into the controller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/find_in_page/js_findinpage_manager.h

Issue 2685393004: [ios] Hoists the FindInPageModel up into the controller. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/find_in_page/js_findinpage_manager.h

diff --git a/ios/chrome/browser/find_in_page/js_findinpage_manager.h b/ios/chrome/browser/find_in_page/js_findinpage_manager.h

index ff4c9df6ed83375bd09af70b76b356cc70d1409d..ce5d2b8f474855127106607086b27d2182e2da68 100644

--- a/ios/chrome/browser/find_in_page/js_findinpage_manager.h

+++ b/ios/chrome/browser/find_in_page/js_findinpage_manager.h

@@ -26,8 +26,8 @@ extern FindInPageEntry FindInPageEntryZero;

// Manager for the injection of the Find In Page JavaScript.

@interface JsFindinpageManager : CRWJSInjectionManager

-// Find In Page model. TODO(justincohen) consider using find_tab_helper.cc.

-@property(strong, nonatomic, readonly) FindInPageModel* findInPageModel;

+// Find In Page model.

+@property(nonatomic, readwrite, strong) FindInPageModel* findInPageModel;

rohitrao (ping after 24h) 2017/02/10 21:07:08 This isn't created by the manager anymore, but I t

// Sets the width and height of the window.

- (void)setWidth:(CGFloat)width height:(CGFloat)height;