[ios] Hoists the FindInPageModel up into the controller.

ios/chrome/browser/find_in_page/find_in_page_controller.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/find_in_page/find_in_page_controller.h"
 
 #import <UIKit/UIKit.h>
 
 #import <cmath>
 #include <memory>
@@ skipping 72 matching lines @@
 
   // True when a find is in progress. Used to avoid running JavaScript during
   // disable when there is nothing to clear.
   BOOL _findStringStarted;
 
   // Bridge to observe the web state from Objective-C.
   std::unique_ptr<web::WebStateObserverBridge> _webStateObserverBridge;
 }
 
 @synthesize delegate = _delegate;
+@synthesize findInPageModel = _findInPageModel;
 
 + (void)setSearchTerm:(NSString*)string {
   gSearchTerm = [string copy];
 }
 
 + (NSString*)searchTerm {
   return gSearchTerm;
 }
 
 - (id)initWithWebState:(web::WebState*)webState
               delegate:(id<FindInPageControllerDelegate>)delegate {
   self = [super init];
   if (self) {
+    _findInPageModel = [[FindInPageModel alloc] init];
     _findInPageJsManager = base::mac::ObjCCastStrict<JsFindinpageManager>(
         [webState->GetJSInjectionReceiver()
             instanceOfClass:[JsFindinpageManager class]]);
+    _findInPageJsManager.findInPageModel = _findInPageModel;

[justincohen, 2017/02/13 18:09:36]

Does this need to be nilled out on dealloc of fipcontroller?

[rohitrao (ping after 24h), 2017/02/14 14:52:49]

I made it a strong reference, so the JS manager will keep the object alive as
long as needed.

     _delegate = delegate;
     _webStateObserverBridge.reset(
         new web::WebStateObserverBridge(webState, self));
     _webViewProxy = webState->GetWebViewProxy();
     [[NSNotificationCenter defaultCenter]
         addObserver:self
            selector:@selector(findBarTextFieldWillBecomeFirstResponder:)
                name:kFindBarTextFieldWillBecomeFirstResponderNotification
              object:nil];
     [[NSNotificationCenter defaultCenter]
         addObserver:self
            selector:@selector(findBarTextFieldDidResignFirstResponder:)
                name:kFindBarTextFieldDidResignFirstResponderNotification
              object:nil];
     DOMAlteringLock::CreateForWebState(webState);
   }
   return self;
 }
 
 - (void)dealloc {
   [[NSNotificationCenter defaultCenter] removeObserver:self];
 }
 
-- (FindInPageModel*)findInPageModel {
-  return [_findInPageJsManager findInPageModel];
-}
-
 - (BOOL)canFindInPage {
   return [_webViewProxy hasSearchableTextContent];
 }
 
 - (void)initFindInPage {
   [_findInPageJsManager inject];
 
   // Initialize the module with our frame size.
   CGRect frame = [_webViewProxy bounds];
   [_findInPageJsManager setWidth:frame.size.width height:frame.size.height];
@@ skipping 228 matching lines @@
 
 - (BOOL)canReleaseDOMLock {
   return NO;
 }
 
 - (void)releaseDOMLockWithCompletionHandler:(ProceduralBlock)completionHandler {
   NOTREACHED();
 }
 
 @end