Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2683713003: [Turbofan] Add more non-arithmetic SIMD operations. (Closed)

Created:
3 years, 10 months ago by bbudge
Modified:
3 years, 10 months ago
Reviewers:
titzer, martyn.capewell
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Add more non-arithmetic SIMD operations. - Renames select, swizzle, and shuffle to be consistent with the S128 and existing S32x4 ops, and reflect that these aren't arithmetic. e.g. I16x8Swizzle -> S16x8Swizzle. - Implements S16x8 and S8x16 Select operations and tests. - Implements S128And, Or, Xor, Not operations and tests. - Implements Swizzle for 32x4 formats. - Refactors test macros that generate SIMD code. TEST=cctest/test-run-wasm-simd/* LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2683713003 Cr-Commit-Position: refs/heads/master@{#43168} Committed: https://chromium.googlesource.com/v8/v8/+/11f88ef53f8e7c5aecfccd52e2a076a73efd413a

Patch Set 1 #

Patch Set 2 : Non-ARM build. #

Patch Set 3 : Fix comment and remove extraneous #defines. #

Patch Set 4 : Remove extra case. #

Patch Set 5 : Fix comments, macro-ize select visitors. #

Patch Set 6 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -161 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 2 3 4 5 2 chunks +43 lines, -9 lines 0 comments Download
M src/compiler/arm/instruction-codes-arm.h View 2 chunks +8 lines, -2 lines 0 comments Download
M src/compiler/arm/instruction-scheduler-arm.cc View 2 chunks +7 lines, -1 line 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 2 3 4 5 5 chunks +24 lines, -8 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 3 4 5 4 chunks +28 lines, -4 lines 0 comments Download
M src/compiler/machine-operator.h View 3 chunks +7 lines, -7 lines 0 comments Download
M src/compiler/machine-operator.cc View 5 chunks +17 lines, -12 lines 0 comments Download
M src/compiler/opcodes.h View 4 chunks +15 lines, -15 lines 0 comments Download
M src/compiler/wasm-compiler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 3 chunks +38 lines, -3 lines 0 comments Download
M src/wasm/wasm-macro-gen.h View 1 chunk +26 lines, -37 lines 0 comments Download
M src/wasm/wasm-opcodes.h View 4 chunks +10 lines, -13 lines 0 comments Download
M src/wasm/wasm-opcodes.cc View 3 chunks +14 lines, -9 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-simd.cc View 9 chunks +87 lines, -36 lines 0 comments Download

Messages

Total messages: 26 (21 generated)
bbudge
3 years, 10 months ago (2017-02-09 15:24:35 UTC) #14
titzer
On 2017/02/09 15:24:35, bbudge wrote: Shuffling the swizzles! lgtm.
3 years, 10 months ago (2017-02-09 23:10:54 UTC) #15
martyn.capewell
ARM bits lgtm
3 years, 10 months ago (2017-02-10 10:59:25 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683713003/100001
3 years, 10 months ago (2017-02-13 20:23:23 UTC) #23
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 20:24:56 UTC) #26
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/11f88ef53f8e7c5aecfccd52e2a076a73ef...

Powered by Google App Engine
This is Rietveld 408576698