URLLoaderMockFactory: clear MemoryCache in unregisterAllURLs

URLLoaderMockFactory: clear MemoryCache in unregisterAllURLs

We used to have this in WebURLLoaderMockFactory but it was moved out of
the factory when I moved it under platform/tests to avoid layering
violations.  Now that MemoryCache and WebCache are both in platform/
we can move it back to the MockFactory, which is more convenient for
majority of tests.

BUG=689341
TBR=peter@chromium.org

Review-Url: https://codereview.chromium.org/2683033005
Cr-Commit-Position: refs/heads/master@{#449891}
Committed: https://chromium.googlesource.com/chromium/src/+/584e0be921ffc96b1b8b400dece9ed18a6af1931

[kinuko, 2017-02-09 15:26:14]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 15:26:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2017-02-09 15:58:45]

Description was changed from

==========
URLLoaderMockFactory: clear MemoryCache in unregisterAllURLs

We used to have this in WebURLLoaderMockFactory but it was moved out of
the factory when I moved it under platform/tests to avoid layering
violations.  Now that MemoryCache and WebCache are both in platform/
we can move it back to the MockFactory, which is more convenient for
majority of tests.

BUG=689341
==========

to

==========
URLLoaderMockFactory: clear MemoryCache in unregisterAllURLs

We used to have this in WebURLLoaderMockFactory but it was moved out of
the factory when I moved it under platform/tests to avoid layering
violations.  Now that MemoryCache and WebCache are both in platform/
we can move it back to the MockFactory, which is more convenient for
majority of tests.

BUG=689341
==========

[kinuko, 2017-02-09 15:58:46]

kinuko@chromium.org changed reviewers:
+ dcheng@chromium.org, japhet@chromium.org

[kinuko, 2017-02-09 15:59:09]

Minor cleanup; can either of you review?

[commit-bot: I haz the power, 2017-02-09 17:09:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 17:09:55]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-02-09 19:42:12]

lgtm with a random thought

https://codereview.chromium.org/2683033005/diff/1/third_party/WebKit/public/p...
File third_party/WebKit/public/platform/WebURLLoaderMockFactory.h (right):

https://codereview.chromium.org/2683033005/diff/1/third_party/WebKit/public/p...
third_party/WebKit/public/platform/WebURLLoaderMockFactory.h:53: virtual void
unregisterAllURLs() = 0;
I wonder if it'd be clearer if it was named:

unregisterAllURLsAndClearMemoryCache()

[kinuko, 2017-02-10 00:01:19]

On 2017/02/09 19:42:12, dcheng wrote:
> lgtm with a random thought
> 
>
https://codereview.chromium.org/2683033005/diff/1/third_party/WebKit/public/p...
> File third_party/WebKit/public/platform/WebURLLoaderMockFactory.h (right):
> 
>
https://codereview.chromium.org/2683033005/diff/1/third_party/WebKit/public/p...
> third_party/WebKit/public/platform/WebURLLoaderMockFactory.h:53: virtual void
> unregisterAllURLs() = 0;
> I wonder if it'd be clearer if it was named:
> 
> unregisterAllURLsAndClearMemoryCache()

Good idea, done.

[kinuko, 2017-02-10 00:04:09]

kinuko@chromium.org changed reviewers:
+ peter@chromium.org

[kinuko, 2017-02-10 00:04:52]

peter@: can you review changes in modules/notifications?

(Minor test-only changes)

[Nate Chapin, 2017-02-10 22:41:11]

LGTM w/nit

https://codereview.chromium.org/2683033005/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.cc
(right):

https://codereview.chromium.org/2683033005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.cc:80:
if (cache)
memoryCache() shouldn't ever return null.

[kinuko, 2017-02-12 02:28:38]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-12 02:28:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2017-02-12 02:28:55]

Description was changed from

==========
URLLoaderMockFactory: clear MemoryCache in unregisterAllURLs

We used to have this in WebURLLoaderMockFactory but it was moved out of
the factory when I moved it under platform/tests to avoid layering
violations.  Now that MemoryCache and WebCache are both in platform/
we can move it back to the MockFactory, which is more convenient for
majority of tests.

BUG=689341
==========

to

==========
URLLoaderMockFactory: clear MemoryCache in unregisterAllURLs

We used to have this in WebURLLoaderMockFactory but it was moved out of
the factory when I moved it under platform/tests to avoid layering
violations.  Now that MemoryCache and WebCache are both in platform/
we can move it back to the MockFactory, which is more convenient for
majority of tests.

BUG=689341
TBR=peter@chromium.org
==========

[commit-bot: I haz the power, 2017-02-12 03:47:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-12 03:47:18]

Dry run: This issue passed the CQ dry run.

[kinuko, 2017-02-12 12:48:41]

https://codereview.chromium.org/2683033005/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.cc
(right):

https://codereview.chromium.org/2683033005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.cc:80:
if (cache)
On 2017/02/10 22:41:11, Nate Chapin wrote:
> memoryCache() shouldn't ever return null.

Done.  Thanks!

[kinuko, 2017-02-12 12:50:52]

Peter: I'm TBR-ing this as the changes are mechanical & test-only.  Please feel
free to comment, uncheck CQ or ask for a follow-up change if necessary.  Thanks!

[kinuko, 2017-02-12 12:51:07]

The CQ bit was checked by kinuko@chromium.org

[kinuko, 2017-02-12 12:51:08]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org,
japhet@chromium.org
Link to the patchset: https://codereview.chromium.org/2683033005/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2017-02-12 12:51:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-12 13:03:27]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486903867491450,
"parent_rev": "08fedb23a2a7223d08c7e63f0e7f009ee5edd3aa", "commit_rev":
"584e0be921ffc96b1b8b400dece9ed18a6af1931"}

[commit-bot: I haz the power, 2017-02-12 13:04:02]

Description was changed from

==========
URLLoaderMockFactory: clear MemoryCache in unregisterAllURLs

We used to have this in WebURLLoaderMockFactory but it was moved out of
the factory when I moved it under platform/tests to avoid layering
violations.  Now that MemoryCache and WebCache are both in platform/
we can move it back to the MockFactory, which is more convenient for
majority of tests.

BUG=689341
TBR=peter@chromium.org
==========

to

==========
URLLoaderMockFactory: clear MemoryCache in unregisterAllURLs

We used to have this in WebURLLoaderMockFactory but it was moved out of
the factory when I moved it under platform/tests to avoid layering
violations.  Now that MemoryCache and WebCache are both in platform/
we can move it back to the MockFactory, which is more convenient for
majority of tests.

BUG=689341
TBR=peter@chromium.org

Review-Url: https://codereview.chromium.org/2683033005
Cr-Commit-Position: refs/heads/master@{#449891}
Committed:
https://chromium.googlesource.com/chromium/src/+/584e0be921ffc96b1b8b400dece9...
==========

[commit-bot: I haz the power, 2017-02-12 13:04:03]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/584e0be921ffc96b1b8b400dece9...