third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp - Issue 2683033005: URLLoaderMockFactory: clear MemoryCache in unregisterAllURLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp

Issue 2683033005: URLLoaderMockFactory: clear MemoryCache in unregisterAllURLs (Closed)

Patch Set: fix Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/resource/FontResourceTest.cpp ('k') | third_party/WebKit/Source/modules/notifications/NotificationResourcesLoaderTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp b/third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp

index 19d5fe9ccae2489429946daf8feb0dcc687dc980..d1da178c2e7b56b272740955db26bf6a7ee3ee3e 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp

+++ b/third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp

@@ -44,8 +44,9 @@ class NotificationImageLoaderTest : public ::testing::Test {

~NotificationImageLoaderTest() override {

m_loader->stop();

- Platform::current()->getURLLoaderMockFactory()->unregisterAllURLs();

- memoryCache()->evictResources();

+ Platform::current()

+ ->getURLLoaderMockFactory()

+ ->unregisterAllURLsAndClearMemoryCache();

}

// Registers a mocked URL. When fetched it will be loaded form the test data