third_party/WebKit/Source/web/tests/ListenerLeakTest.cpp - Issue 2683033005: URLLoaderMockFactory: clear MemoryCache in unregisterAllURLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/ListenerLeakTest.cpp

Issue 2683033005: URLLoaderMockFactory: clear MemoryCache in unregisterAllURLs (Closed)

Patch Set: fix Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/ListenerLeakTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/ListenerLeakTest.cpp b/third_party/WebKit/Source/web/tests/ListenerLeakTest.cpp

index 6be40e699dd67434ed9385ea1e5e8dc032c170c2..f6a9033be02d88b799f7fd2daed3b39112189bbe 100644

--- a/third_party/WebKit/Source/web/tests/ListenerLeakTest.cpp

+++ b/third_party/WebKit/Source/web/tests/ListenerLeakTest.cpp

@@ -33,7 +33,6 @@

#include "platform/testing/URLTestHelpers.h"

#include "platform/testing/UnitTestHelpers.h"

#include "public/platform/Platform.h"

-#include "public/platform/WebCache.h"

#include "public/platform/WebURLLoaderMockFactory.h"

#include "public/web/WebView.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -96,8 +95,9 @@ class ListenerLeakTest : public ::testing::Test {

}

void TearDown() override {

- Platform::current()->getURLLoaderMockFactory()->unregisterAllURLs();

- WebCache::clear();

+ Platform::current()

+ ->getURLLoaderMockFactory()

+ ->unregisterAllURLsAndClearMemoryCache();

}

protected: