third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.cc - Issue 2683033005: URLLoaderMockFactory: clear MemoryCache in unregisterAllURLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.cc

Issue 2683033005: URLLoaderMockFactory: clear MemoryCache in unregisterAllURLs (Closed)

Patch Set: fix Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.h ('k') | third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.cc

diff --git a/third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.cc b/third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.cc

index a5704c040299ed50db47d2af331fee0e83923945..9d60cd27cd816532086b8c22c488c85fec66c658 100644

--- a/third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.cc

+++ b/third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.cc

@@ -8,6 +8,7 @@

#include "base/files/file_util.h"

#include "base/run_loop.h"

+#include "platform/loader/fetch/MemoryCache.h"

#include "platform/testing/TestingPlatformSupport.h"

#include "platform/testing/UnitTestHelpers.h"

#include "platform/testing/weburl_loader_mock.h"

@@ -72,9 +73,10 @@ void WebURLLoaderMockFactoryImpl::unregisterURL(const blink::WebURL& url) {

url_to_error_info_.remove(error_iter);

}

-void WebURLLoaderMockFactoryImpl::unregisterAllURLs() {

+void WebURLLoaderMockFactoryImpl::unregisterAllURLsAndClearMemoryCache() {

url_to_response_info_.clear();

url_to_error_info_.clear();

+ memoryCache()->evictResources();

}

void WebURLLoaderMockFactoryImpl::serveAsynchronousRequests() {