Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2682993002: Pay some naming debt. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, Vyacheslav Egorov (Google), rmacnak, Kevin Millikin (Google)
Target Ref:
refs/heads/master
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -278 lines) Patch
M pkg/front_end/lib/src/fasta/builder/builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D pkg/front_end/lib/src/fasta/builder/interface_type_builder.dart View 1 chunk +0 lines, -73 lines 0 comments Download
A + pkg/front_end/lib/src/fasta/builder/named_type_builder.dart View 3 chunks +3 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart View 2 chunks +6 lines, -6 lines 0 comments Download
D pkg/front_end/lib/src/fasta/kernel/kernel_interface_type_builder.dart View 1 chunk +0 lines, -94 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 7 chunks +13 lines, -13 lines 0 comments Download
A + pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart View 2 chunks +4 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 5 chunks +10 lines, -10 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_type_variable_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/outline.dart View 4 chunks +12 lines, -13 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 6 chunks +7 lines, -7 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 8 chunks +28 lines, -28 lines 0 comments Download
M pkg/front_end/lib/src/fasta/testing/suite.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/front_end/test/fasta/testing.json View 2 chunks +2 lines, -3 lines 0 comments Download
M utils/kernel-service/kernel-service.dart View 4 chunks +10 lines, -10 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
ahe
https://codereview.chromium.org/2682993002/diff/1/utils/kernel-service/kernel-service.dart File utils/kernel-service/kernel-service.dart (right): https://codereview.chromium.org/2682993002/diff/1/utils/kernel-service/kernel-service.dart#newcode350 utils/kernel-service/kernel-service.dart:350: request.response.write(JSON.encode(result)); JSON.encode calls toJson implicitly, and it isn't defined ...
3 years, 10 months ago (2017-02-08 16:55:29 UTC) #2
Johnni Winther
lgtm
3 years, 10 months ago (2017-02-09 08:59:02 UTC) #3
ahe
FYI: CC'ing other contributors to utils/kernel-service/kernel-service.dart
3 years, 10 months ago (2017-02-09 09:04:17 UTC) #4
Vyacheslav Egorov (Google)
https://codereview.chromium.org/2682993002/diff/1/utils/kernel-service/kernel-service.dart File utils/kernel-service/kernel-service.dart (right): https://codereview.chromium.org/2682993002/diff/1/utils/kernel-service/kernel-service.dart#newcode350 utils/kernel-service/kernel-service.dart:350: request.response.write(JSON.encode(result)); On 2017/02/08 16:55:29, ahe wrote: > JSON.encode calls ...
3 years, 10 months ago (2017-02-09 09:26:38 UTC) #6
ahe
3 years, 10 months ago (2017-02-09 12:10:33 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c13730e8eac5e5c5e94c8a6c1cba993a0ddeb7fa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698