Pay some naming debt.

utils/kernel-service/kernel-service.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// This is an interface to the Dart Kernel parser and Kernel binary generator.
 ///
 /// It is used by the kernel-isolate to load Dart source code and generate
 /// Kernel binary format.
 ///
 /// This is either invoked as the root script of the Kernel isolate when used
@@ skipping 34 matching lines @@
 
 import 'package:kernel/analyzer/loader.dart';
 import 'package:kernel/binary/ast_to_binary.dart';
 import 'package:kernel/kernel.dart';
 import 'package:kernel/target/targets.dart';
 
 import 'package:front_end/src/fasta/dill/dill_target.dart' show DillTarget;
 import 'package:front_end/src/fasta/translate_uri.dart' show TranslateUri;
 import 'package:front_end/src/fasta/ticker.dart' show Ticker;
 import 'package:front_end/src/fasta/kernel/kernel_target.dart'
-    show KernelSourceTarget;
+    show KernelTarget;
 import 'package:front_end/src/fasta/ast_kind.dart' show AstKind;
 import 'package:front_end/src/fasta/errors.dart' show InputError;
 
 const bool verbose = const bool.fromEnvironment('DFE_VERBOSE');
 const int workerPort = const int.fromEnvironment('DFE_WORKER_PORT') ?? 0;
 const bool useFasta = const bool.fromEnvironment('DFE_USE_FASTA');
 
 class DataSink implements Sink<List<int>> {
   final BytesBuilder builder = new BytesBuilder();
 
@@ skipping 89 matching lines @@
   }
 
   Target target = getTarget("vm", new TargetFlags(strongMode: false));
 
   Program program;
   if (useFasta) {
     final uriTranslator = await TranslateUri.parse(new Uri.file(packageConfig));
     final Ticker ticker = new Ticker(isVerbose: verbose);
     final DillTarget dillTarget = new DillTarget(ticker, uriTranslator);
     dillTarget.read(new Uri.directory(sdkPath).resolve('platform.dill'));
-    final KernelSourceTarget sourceTarget =
-        new KernelSourceTarget(dillTarget, uriTranslator);
+    final KernelTarget kernelTarget =
+        new KernelTarget(dillTarget, uriTranslator);
     try {
-      sourceTarget.read(fileName);
+      kernelTarget.read(fileName);
       await dillTarget.writeOutline(null);
-      program = await sourceTarget.writeOutline(null);
-      program = await sourceTarget.writeProgram(null, AstKind.Kernel);
-      if (sourceTarget.errors.isNotEmpty) {
-        return new CompilationError(sourceTarget.errors
+      program = await kernelTarget.writeOutline(null);
+      program = await kernelTarget.writeProgram(null, AstKind.Kernel);
+      if (kernelTarget.errors.isNotEmpty) {
+        return new CompilationError(kernelTarget.errors
             .map((err) => err.toString())
             .toList(growable: false));
       }
     } on InputError catch (e) {
       return new CompilationError(<String>[e.error]);
     }
   } else {
     DartOptions dartOptions = new DartOptions(
         strongMode: false,
         strongModeSdk: false,
@@ skipping 156 matching lines @@
           loader, scriptUri, packagesUri.path, patchedSdk.path);
 
       if (result is CompilationOk) {
         request.response.statusCode = HttpStatus.OK;
         request.response.headers.contentType = ContentType.BINARY;
         request.response.add(result.binary);
         request.response.close();
       } else {
         request.response.statusCode = HttpStatus.INTERNAL_SERVER_ERROR;
         request.response.headers.contentType = ContentType.TEXT;
-        request.response.write(JSON.encode(result.toJson()));
+        request.response.write(JSON.encode(result));

[ahe, 2017/02/08 16:55:29]

JSON.encode calls toJson implicitly, and it isn't defined on CompilationResult.

[Vyacheslav Egorov (Google), 2017/02/09 09:26:38]

Sweet. I did not know that. Thanks for fixing.

         request.response.close();
       }
     });
     ProcessSignal.SIGTERM.watch().first.then((_) => server.close());
   });
 }
 
 train(String scriptUri) {
   // TODO(28532): Enable on Windows.
   if (Platform.isWindows) return;
@@ skipping 23 matching lines @@
     // provides a script to compile to warm-up generated code.
     train(args[1]);
   } else {
     // Entry point for the Kernel isolate.
     return new RawReceivePort()..handler = _processLoadRequest;
   }
 }
 
 // This duplicates functionality from the Loader which we can't easily
 // access from here.
-Uri _findPackagesFile(Uri base) async {
+Future<Uri> _findPackagesFile(Uri base) async {
   var dir = new File.fromUri(base).parent;
   while (true) {
     final packagesFile = dir.uri.resolve(".packages");
     if (await new File.fromUri(packagesFile).exists()) {
       return packagesFile;
     }
     if (dir.parent.path == dir.path) {
       break;
     }
     dir = dir.parent;
   }
   return null;
 }