Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: pkg/front_end/lib/src/fasta/builder/named_type_builder.dart

Issue 2682993002: Pay some naming debt. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/builder/named_type_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/builder/interface_type_builder.dart b/pkg/front_end/lib/src/fasta/builder/named_type_builder.dart
similarity index 85%
rename from pkg/front_end/lib/src/fasta/builder/interface_type_builder.dart
rename to pkg/front_end/lib/src/fasta/builder/named_type_builder.dart
index cd34e65336a0a93f61aa75f5c36e6e0d63a5f249..b8232bc3395f5a54743796c44a1dec27461780a7 100644
--- a/pkg/front_end/lib/src/fasta/builder/interface_type_builder.dart
+++ b/pkg/front_end/lib/src/fasta/builder/named_type_builder.dart
@@ -14,9 +14,7 @@ import 'builder.dart' show
TypeBuilder,
TypeDeclarationBuilder;
-// TODO(ahe): This isn't really an interface type. Find better name. Possibly,
-// `NamedTypeBuilder`.
-abstract class InterfaceTypeBuilder<T extends TypeBuilder> extends TypeBuilder {
+abstract class NamedTypeBuilder<T extends TypeBuilder> extends TypeBuilder {
final String name;
final List<T> arguments;
@@ -25,7 +23,7 @@ abstract class InterfaceTypeBuilder<T extends TypeBuilder> extends TypeBuilder {
void set builder(TypeDeclarationBuilder b);
- InterfaceTypeBuilder(this.name, this.arguments);
+ NamedTypeBuilder(this.name, this.arguments);
InvalidTypeBuilder buildInvalidType(String name);
@@ -55,7 +53,7 @@ abstract class InterfaceTypeBuilder<T extends TypeBuilder> extends TypeBuilder {
builder = buildInvalidType(name);
}
- String get debugName => "InterfaceTypeBuilder";
+ String get debugName => "NamedTypeBuilder";
StringBuffer printOn(StringBuffer buffer) {
buffer.write(name);

Powered by Google App Engine
This is Rietveld 408576698