Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart

Issue 2682993002: Pay some naming debt. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_interface_type_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart
similarity index 87%
rename from pkg/front_end/lib/src/fasta/kernel/kernel_interface_type_builder.dart
rename to pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart
index ffbe6cb2cfbce3a1d75e545a2503c944cb7c11f6..b7ca156764bc47678dd467dc845466cca49fc7f3 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_interface_type_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart
@@ -14,21 +14,19 @@ import '../errors.dart' show
inputError;
import 'kernel_builder.dart' show
- InterfaceTypeBuilder,
KernelClassBuilder,
KernelInvalidTypeBuilder,
KernelTypeBuilder,
+ NamedTypeBuilder,
TypeBuilder,
TypeDeclarationBuilder,
TypeVariableBuilder;
-// TODO(ahe): This isn't really an interface type. Find better name, for
-// example, KernelNamedTypeBuilder.
-class KernelInterfaceTypeBuilder extends InterfaceTypeBuilder<KernelTypeBuilder>
+class KernelNamedTypeBuilder extends NamedTypeBuilder<KernelTypeBuilder>
implements KernelTypeBuilder {
TypeDeclarationBuilder<KernelTypeBuilder, DartType> builder;
- KernelInterfaceTypeBuilder(String name, List<KernelTypeBuilder> arguments)
+ KernelNamedTypeBuilder(String name, List<KernelTypeBuilder> arguments)
: super(name, arguments);
KernelInvalidTypeBuilder buildInvalidType(String name) {
@@ -85,7 +83,7 @@ class KernelInterfaceTypeBuilder extends InterfaceTypeBuilder<KernelTypeBuilder>
i++;
}
if (arguments != null) {
- return new KernelInterfaceTypeBuilder(name, arguments)
+ return new KernelNamedTypeBuilder(name, arguments)
..builder = builder;
}
}

Powered by Google App Engine
This is Rietveld 408576698