Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Unified Diff: pkg/front_end/lib/src/fasta/source/outline_builder.dart

Issue 2682993002: Pay some naming debt. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/source/outline_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/source/outline_builder.dart b/pkg/front_end/lib/src/fasta/source/outline_builder.dart
index 95e49b79091f5ccd0c295670dfc527bae2279553..68d70fb9af3936cd49c95cff970c200a5a451517 100644
--- a/pkg/front_end/lib/src/fasta/source/outline_builder.dart
+++ b/pkg/front_end/lib/src/fasta/source/outline_builder.dart
@@ -183,8 +183,8 @@ class OutlineBuilder extends UnhandledListener {
}
@override
- void beginClassDeclaration(Token token) {
- library.beginNestedScope();
+ void beginClassDeclaration(Token begin) {
+ library.beginNestedDeclaration();
}
@override
@@ -211,7 +211,7 @@ class OutlineBuilder extends UnhandledListener {
@override
void beginTopLevelMethod(Token token, Token name) {
- library.beginNestedScope(hasMembers: false);
+ library.beginNestedDeclaration(hasMembers: false);
}
@override
@@ -246,7 +246,7 @@ class OutlineBuilder extends UnhandledListener {
@override
void beginMethod(Token token, Token name) {
- library.beginNestedScope(hasMembers: false);
+ library.beginNestedDeclaration(hasMembers: false);
}
@override
@@ -282,7 +282,7 @@ class OutlineBuilder extends UnhandledListener {
@override
void beginNamedMixinApplication(Token token) {
- library.beginNestedScope(hasMembers: false);
+ library.beginNestedDeclaration(hasMembers: false);
}
@override
@@ -311,7 +311,7 @@ class OutlineBuilder extends UnhandledListener {
debugEvent("Type");
List<TypeBuilder> arguments = pop();
String name = pop();
- push(library.addInterfaceType(name, arguments));
+ push(library.addNamedType(name, arguments));
}
@override
@@ -412,7 +412,7 @@ class OutlineBuilder extends UnhandledListener {
@override
void beginFunctionTypeAlias(Token token) {
- library.beginNestedScope();
+ library.beginNestedDeclaration(hasMembers: false);
}
@override

Powered by Google App Engine
This is Rietveld 408576698