Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2681793002: Landing Recent QUIC changes until 5:30 PM, Feb 3, 2017 UTC-5 (Closed)

Created:
3 years, 10 months ago by Fan Yang
Modified:
3 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC changes until 5:30 PM, Feb 3, 2017 UTC-5 Flip FLAGS_quic_reloadable_flag_quic_use_event_time to true. https://codereview.chromium.org/2680803002/ Remove path id from IV in QUIC encrytion algorithms. Merge internal change: 146517512 https://codereview.chromium.org/2679673005/ Get rid of more va_arg methods in favor of std::vector<> arguments. Much simpler and more readable method implementations as a result. Merge internal change: 146383132 https://codereview.chromium.org/2671273003/ Remove two unused ProofSourceForTesting. Merge internal change: 146291369 https://codereview.chromium.org/2676343004/ Replace va_arg version of crypto_test_utils::Message with a more modern vector argument version. Couple of other simplifications: - always build a CHLO (this method was never used for anything else) - make padding an explicit argument rather than a weird special case - remove disabling of clang-format as things look good with this change Merge internal change: 146270645 https://codereview.chromium.org/2678973002/ Deprecate FLAGS_quic_reloadable_flag_enable_async_get_proof Merge internal change: 146243587 https://codereview.chromium.org/2679783003/ Deprecate FLAGS_quic_reloadable_flag_quic_only_5rto_client_side in the disabled state, now that it's been disabled for over a month. Merge internal change: 146241134 https://codereview.chromium.org/2678953002/ Convert class-full-of-statics CryptoTestUtils into a namespace Merge internal change: 146240722 https://codereview.chromium.org/2671333004/ Deprecate FLAGS_quic_reloadable_flag_quic_more_conservative_retransmission_alarm Merge internal change: 146149718 https://codereview.chromium.org/2671303003/ Replace crypto::SecureHash with calls to SHA256. Merge internal change: 146047815 https://codereview.chromium.org/2672403003/ Make QUIC force HOL-blocking mode only apply to v36. This is basically a no-op since neither v36 nor v37 are enabled. Merge internal change: 146004954 https://codereview.chromium.org/2678003003/ Review-Url: https://codereview.chromium.org/2681793002 Cr-Commit-Position: refs/heads/master@{#448645} Committed: https://chromium.googlesource.com/chromium/src/+/f5f4cd51c92ce55d2eaadd371c6aa1ad0aa2812e

Patch Set 1 #

Patch Set 2 : sync and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1129 lines, -1636 lines) Patch
M net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/crypto/proof_source_chromium.h View 2 chunks +9 lines, -9 lines 0 comments Download
M net/quic/chromium/crypto/proof_source_chromium.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M net/quic/chromium/crypto/proof_test_chromium.cc View 1 4 chunks +33 lines, -45 lines 0 comments Download
M net/quic/chromium/crypto_test_utils_chromium.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_chromium_client_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_end_to_end_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_http_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_network_transaction_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_stream_factory_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_test_packet_maker.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M net/quic/core/crypto/aead_base_decrypter.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/aead_base_decrypter.cc View 2 chunks +1 line, -5 lines 0 comments Download
M net/quic/core/crypto/aead_base_encrypter.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/aead_base_encrypter.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M net/quic/core/crypto/aes_128_gcm_12_decrypter_test.cc View 1 chunk +1 line, -5 lines 0 comments Download
M net/quic/core/crypto/cert_compressor_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/crypto/chacha20_poly1305_decrypter_test.cc View 1 chunk +1 line, -5 lines 0 comments Download
M net/quic/core/crypto/chacha20_poly1305_encrypter_test.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/quic/core/crypto/channel_id_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/crypto_framer_test.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M net/quic/core/crypto/crypto_secret_boxer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/core/crypto/crypto_server_test.cc View 32 chunks +262 lines, -353 lines 0 comments Download
M net/quic/core/crypto/crypto_utils.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M net/quic/core/crypto/null_decrypter.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/null_decrypter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/null_decrypter_test.cc View 6 chunks +18 lines, -18 lines 0 comments Download
M net/quic/core/crypto/null_encrypter.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/null_encrypter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/null_encrypter_test.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M net/quic/core/crypto/proof_source.h View 2 chunks +5 lines, -27 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config_test.cc View 18 chunks +20 lines, -20 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.h View 2 chunks +0 lines, -26 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 8 chunks +34 lines, -119 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config_test.cc View 1 10 chunks +70 lines, -77 lines 0 comments Download
M net/quic/core/crypto/quic_decrypter.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/quic_encrypter.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/quic_client_promised_info_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_client_push_promise_index_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_connection.cc View 1 chunk +1 line, -4 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 16 chunks +16 lines, -58 lines 0 comments Download
M net/quic/core/quic_crypto_client_stream.h View 2 chunks +0 lines, -2 lines 0 comments Download
M net/quic/core/quic_crypto_client_stream_test.cc View 7 chunks +37 lines, -17 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.h View 2 chunks +0 lines, -2 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.cc View 4 chunks +22 lines, -52 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream_test.cc View 9 chunks +13 lines, -12 lines 0 comments Download
M net/quic/core/quic_crypto_stream_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 3 chunks +1 line, -15 lines 0 comments Download
M net/quic/core/quic_framer.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/quic_framer.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M net/quic/core/quic_framer_test.cc View 13 chunks +15 lines, -23 lines 0 comments Download
M net/quic/core/quic_sent_packet_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/core/quic_server_session_base_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/core/quic_session_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_spdy_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quartc/quartc_session.cc View 1 chunk +10 lines, -18 lines 0 comments Download
M net/quic/quartc/quartc_session_test.cc View 1 chunk +8 lines, -17 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.h View 1 chunk +186 lines, -197 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 20 chunks +128 lines, -155 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils_test.cc View 2 chunks +14 lines, -18 lines 0 comments Download
M net/quic/test_tools/failing_proof_source.h View 1 chunk +0 lines, -9 lines 0 comments Download
M net/quic/test_tools/failing_proof_source.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M net/quic/test_tools/fake_proof_source.h View 1 chunk +0 lines, -8 lines 0 comments Download
M net/quic/test_tools/fake_proof_source.cc View 4 chunks +9 lines, -31 lines 0 comments Download
M net/quic/test_tools/quic_crypto_server_config_peer.h View 1 1 chunk +10 lines, -10 lines 0 comments Download
M net/quic/test_tools/quic_crypto_server_config_peer.cc View 1 chunk +5 lines, -30 lines 0 comments Download
M net/quic/test_tools/quic_stream_peer.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_stream_peer.cc View 1 chunk +6 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/chlo_extractor_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/tools/quic/quic_client_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 4 chunks +27 lines, -35 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 6 chunks +21 lines, -29 lines 0 comments Download
M net/tools/quic/quic_server_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_simple_client_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_spdy_client_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/stateless_rejector_test.cc View 5 chunks +37 lines, -45 lines 0 comments Download
M net/url_request/url_request_quic_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (12 generated)
Fan Yang
3 years, 10 months ago (2017-02-07 15:17:26 UTC) #7
Ryan Hamilton
lgtm
3 years, 10 months ago (2017-02-07 15:24:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681793002/20001
3 years, 10 months ago (2017-02-07 16:51:03 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 16:57:50 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f5f4cd51c92ce55d2eaadd371c6a...

Powered by Google App Engine
This is Rietveld 408576698