Get rid of more va_arg methods in favor of std::vector<> arguments. Much simpler and more readable …

Get rid of more va_arg methods in favor of std::vector<> arguments. Much simpler and more readable method implementations as a result.

Merge internal change: 146383132

R=rch@chromium.org
BUG=

[Fan Yang, 2017-02-06 21:32:06]

The CQ bit was checked by fayang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 21:32:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 22:04:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 22:04:07]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ryan Hamilton, 2017-02-06 23:14:08]

Any idea why the tests are failing on some platforms?

[Fan Yang, 2017-02-07 14:40:40]

The CQ bit was checked by fayang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 14:40:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fan Yang, 2017-02-07 14:41:53]

On 2017/02/06 23:14:08, Ryan Hamilton wrote:
> Any idea why the tests are failing on some platforms?

It seems chromium does not support {} as a initialize of empty vector parameter.
So I change it to an actual empty vector.

[Ryan Hamilton, 2017-02-07 14:57:26]

Bummer! Thanks for fixing.

LGTM

https://codereview.chromium.org/2671273003/diff/20001/net/quic/core/crypto/qu...
File net/quic/core/crypto/quic_crypto_server_config_test.cc (right):

https://codereview.chromium.org/2671273003/diff/20001/net/quic/core/crypto/qu...
net/quic/core/crypto/quic_crypto_server_config_test.cc:357:
test_peer_.CheckConfigs(empty_configs);
Your call, but you could also do:

test_peer_.CheckConfigs(std::vector<std::pair<string, bool>>());

[Fan Yang, 2017-02-07 15:06:51]

The CQ bit was checked by fayang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 15:07:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fan Yang, 2017-02-07 15:17:55]

On 2017/02/07 14:57:26, Ryan Hamilton wrote:
> Bummer! Thanks for fixing.
> 
> LGTM
> 
>
https://codereview.chromium.org/2671273003/diff/20001/net/quic/core/crypto/qu...
> File net/quic/core/crypto/quic_crypto_server_config_test.cc (right):
> 
>
https://codereview.chromium.org/2671273003/diff/20001/net/quic/core/crypto/qu...
> net/quic/core/crypto/quic_crypto_server_config_test.cc:357:
> test_peer_.CheckConfigs(empty_configs);
> Your call, but you could also do:
> 
> test_peer_.CheckConfigs(std::vector<std::pair<string, bool>>());

Done. Thank you, Ryan!

[commit-bot: I haz the power, 2017-02-07 16:12:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 16:12:32]

Dry run: This issue passed the CQ dry run.

[Fan Yang, 2017-02-07 18:11:38]

Description was changed from

==========
Get rid of more va_arg methods in favor of std::vector<> arguments. Much simpler
and more readable method implementations as a result.

Merge internal change: 146383132

R=rch@chromium.org
BUG=
==========

to

==========
Get rid of more va_arg methods in favor of std::vector<> arguments. Much simpler
and more readable method implementations as a result.

Merge internal change: 146383132

R=rch@chromium.org
BUG=
==========