Issue 2678973002: Replace va_arg version of crypto_test_utils::Message with a more modern vector argument version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2678973002: Replace va_arg version of crypto_test_utils::Message with a more modern vector argument version. (Closed)

Created:
3 years, 10 months ago by Fan Yang

Modified:
3 years, 10 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Replace va_arg version of crypto_test_utils::Message with a more modern vector argument version. Couple of other simplifications: - always build a CHLO (this method was never used for anything else) - make padding an explicit argument rather than a weird special case - remove disabling of clang-format as things look good with this change Merge internal change: 146270645 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+345 lines, -480 lines)			Patch
M	net/quic/core/crypto/crypto_server_test.cc	View	23 chunks	+246 lines, -336 lines	0 comments	Download
M	net/quic/test_tools/crypto_test_utils.h	View	1 chunk	+14 lines, -12 lines	0 comments	Download
M	net/quic/test_tools/crypto_test_utils.cc	View	3 chunks	+29 lines, -56 lines	0 comments	Download
M	net/quic/test_tools/crypto_test_utils_test.cc	View	1 chunk	+9 lines, -13 lines	0 comments	Download
M	net/tools/quic/quic_dispatcher_test.cc	View	2 chunks	+13 lines, -21 lines	0 comments	Download
M	net/tools/quic/stateless_rejector_test.cc	View	4 chunks	+34 lines, -42 lines	0 comments	Download

Depends on Patchset:

Issue 2679783003 Patch 1

Dependent Patchsets:

Issue 2676343004 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages