Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2679673005: Remove path id from IV in QUIC encrytion algorithms. (Closed)

Created:
3 years, 10 months ago by Fan Yang
Modified:
3 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove path id from IV in QUIC encrytion algorithms. Merge internal change: 146517512 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -134 lines) Patch
M net/quic/chromium/quic_test_packet_maker.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M net/quic/core/crypto/aead_base_decrypter.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/aead_base_decrypter.cc View 2 chunks +1 line, -5 lines 0 comments Download
M net/quic/core/crypto/aead_base_encrypter.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/aead_base_encrypter.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M net/quic/core/crypto/aes_128_gcm_12_decrypter_test.cc View 1 chunk +1 line, -5 lines 0 comments Download
M net/quic/core/crypto/chacha20_poly1305_decrypter_test.cc View 1 chunk +1 line, -5 lines 0 comments Download
M net/quic/core/crypto/chacha20_poly1305_encrypter_test.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/quic/core/crypto/crypto_secret_boxer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/core/crypto/null_decrypter.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/null_decrypter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/null_decrypter_test.cc View 6 chunks +18 lines, -18 lines 0 comments Download
M net/quic/core/crypto/null_encrypter.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/null_encrypter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/null_encrypter_test.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/crypto/quic_decrypter.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/crypto/quic_encrypter.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/quic_connection_test.cc View 13 chunks +15 lines, -18 lines 0 comments Download
M net/quic/core/quic_framer.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/core/quic_framer.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M net/quic/core/quic_framer_test.cc View 13 chunks +15 lines, -23 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/chlo_extractor_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 2671273003 Patch 1

Dependent Patchsets:

Issue 2680803002 Patch 1

Messages

Total messages: 6 (4 generated)
Fan Yang
3 years, 10 months ago (2017-02-06 21:37:59 UTC) #1
Ryan Hamilton
3 years, 10 months ago (2017-02-06 23:14:51 UTC) #6 
lgtm

Powered by Google App Engine
This is Rietveld 408576698