Actually handle the Vary header in blink, rather than punting on sight.

Actually handle the Vary header in blink, rather than punting on sight.

BUG=527789, 537940, 602198, 614945
TEST=ResourceTest.Vary

Review-Url: https://codereview.chromium.org/2681233002
Cr-Commit-Position: refs/heads/master@{#449438}
Committed: https://chromium.googlesource.com/chromium/src/+/ffefd4173f178d76449fc51f5dc22bfd7e120e03

[Nate Chapin, 2017-02-09 00:56:55]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 00:57:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 06:04:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 06:04:38]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2017-02-09 17:40:26]

Description was changed from

==========
Actually handle the Vary header in blink, rather than punting on sight.

BUG=
==========

to

==========
Actually handle the Vary header in blink, rather than punting on sight.

BUG=527789,537940,602198,614945
==========

[Nate Chapin, 2017-02-09 20:03:30]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 20:04:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nate Chapin, 2017-02-09 20:09:45]

Description was changed from

==========
Actually handle the Vary header in blink, rather than punting on sight.

BUG=527789,537940,602198,614945
==========

to

==========
Actually handle the Vary header in blink, rather than punting on sight.

BUG=527789,537940,602198,614945
TEST=ResourceTest.Vary
==========

[Nate Chapin, 2017-02-09 20:12:38]

japhet@chromium.org changed reviewers:
+ yoav@yoav.ws

[Nate Chapin, 2017-02-09 20:12:39]

This means we now have two different implementations for Vary header handling
(the other is net/http/http_vary_data.h), but the net/ implementation doesn't
look easily reusable in blink.

Also, the logic is simple enough (and the parse is already in HTTPParser, thanks
yoav!) that duplicating the logic seems worth it to make the MemoryCache reuse
behavior better.

[commit-bot: I haz the power, 2017-02-09 22:05:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 22:05:41]

Dry run: This issue passed the CQ dry run.

[Yoav Weiss, 2017-02-09 22:17:52]

On 2017/02/09 20:12:39, Nate Chapin wrote:
> This means we now have two different implementations for Vary header handling
> (the other is net/http/http_vary_data.h), but the net/ implementation doesn't
> look easily reusable in blink.
> 
> Also, the logic is simple enough (and the parse is already in HTTPParser,
thanks
> yoav!) that duplicating the logic seems worth it to make the MemoryCache reuse
> behavior better.

That is awesome! LGTM!

[Nate Chapin, 2017-02-09 22:20:15]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2017-02-09 22:20:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 22:26:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486678815475480,
"parent_rev": "323eef424004ff2d2e9166377fe208b164ae4c8a", "commit_rev":
"ffefd4173f178d76449fc51f5dc22bfd7e120e03"}

[commit-bot: I haz the power, 2017-02-09 22:26:37]

Description was changed from

==========
Actually handle the Vary header in blink, rather than punting on sight.

BUG=527789,537940,602198,614945
TEST=ResourceTest.Vary
==========

to

==========
Actually handle the Vary header in blink, rather than punting on sight.

BUG=527789,537940,602198,614945
TEST=ResourceTest.Vary

Review-Url: https://codereview.chromium.org/2681233002
Cr-Commit-Position: refs/heads/master@{#449438}
Committed:
https://chromium.googlesource.com/chromium/src/+/ffefd4173f178d76449fc51f5dc2...
==========

[commit-bot: I haz the power, 2017-02-09 22:26:39]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ffefd4173f178d76449fc51f5dc2...