third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp - Issue 2681233002: Actually handle the Vary header in blink, rather than punting on sight.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp

Issue 2681233002: Actually handle the Vary header in blink, rather than punting on sight. (Closed)

Patch Set: Remove whitespace handling and case sensitivity cases Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp ('k') | third_party/WebKit/Source/platform/loader/fetch/ResourceTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp

diff --git a/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp b/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp

index 3cd79b567c3386e8600a67997d670a468d47bf22..6be9d2a9a48aa286213566de6b06c2d0278fa14a 100644

--- a/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp

+++ b/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp

@@ -154,7 +154,7 @@ TEST_F(ResourceFetcherTest, Vary) {

response.setHTTPHeaderField(HTTPNames::Vary, "*");

resource->responseReceived(response, nullptr);

resource->finish();

- ASSERT_TRUE(resource->hasVaryHeader());

+ ASSERT_TRUE(resource->mustReloadDueToVaryHeader(url));

ResourceFetcher* fetcher = ResourceFetcher::create(context());

ResourceRequest resourceRequest(url);

@@ -220,7 +220,7 @@ TEST_F(ResourceFetcherTest, VaryOnBack) {

response.setHTTPHeaderField(HTTPNames::Vary, "*");

resource->responseReceived(response, nullptr);

resource->finish();

- ASSERT_TRUE(resource->hasVaryHeader());

+ ASSERT_TRUE(resource->mustReloadDueToVaryHeader(url));

ResourceRequest resourceRequest(url);

resourceRequest.setRequestContext(WebURLRequest::RequestContextInternal);

@@ -245,7 +245,7 @@ TEST_F(ResourceFetcherTest, VaryResource) {

Resource* resource = MockResource::fetch(fetchRequestOriginal, fetcher);

ASSERT_TRUE(resource);

Platform::current()->getURLLoaderMockFactory()->serveAsynchronousRequests();

- ASSERT_TRUE(resource->hasVaryHeader());

+ ASSERT_TRUE(resource->mustReloadDueToVaryHeader(url));

FetchRequest fetchRequest = FetchRequest(url, FetchInitiatorInfo());

Resource* newResource = MockResource::fetch(fetchRequest, fetcher);