Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp

Issue 2681233002: Actually handle the Vary header in blink, rather than punting on sight. (Closed)
Patch Set: Remove whitespace handling and case sensitivity cases Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org) 3 Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org) 4 Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
5 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All 5 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
6 rights reserved. 6 rights reserved.
7 Copyright (C) 2009 Torch Mobile Inc. http://www.torchmobile.com/ 7 Copyright (C) 2009 Torch Mobile Inc. http://www.torchmobile.com/
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 952 matching lines...) Expand 10 before | Expand all | Expand 10 after
963 return Reload; 963 return Reload;
964 } 964 }
965 965
966 // List of available images logic allows images to be re-used without cache 966 // List of available images logic allows images to be re-used without cache
967 // validation. We restrict this only to images from memory cache which are the 967 // validation. We restrict this only to images from memory cache which are the
968 // same as the version in the current document. 968 // same as the version in the current document.
969 if (type == Resource::Image && 969 if (type == Resource::Image &&
970 existingResource == cachedResource(request.url())) 970 existingResource == cachedResource(request.url()))
971 return Use; 971 return Use;
972 972
973 // Defer to the browser process cache for Vary header handling. 973 if (existingResource->mustReloadDueToVaryHeader(request))
974 if (existingResource->hasVaryHeader())
975 return Reload; 974 return Reload;
976 975
977 // If any of the redirects in the chain to loading the resource were not 976 // If any of the redirects in the chain to loading the resource were not
978 // cacheable, we cannot reuse our cached resource. 977 // cacheable, we cannot reuse our cached resource.
979 if (!existingResource->canReuseRedirectChain()) { 978 if (!existingResource->canReuseRedirectChain()) {
980 RESOURCE_LOADING_DVLOG(1) << "ResourceFetcher::determineRevalidationPolicy " 979 RESOURCE_LOADING_DVLOG(1) << "ResourceFetcher::determineRevalidationPolicy "
981 "reloading due to an uncacheable redirect"; 980 "reloading due to an uncacheable redirect";
982 return Reload; 981 return Reload;
983 } 982 }
984 983
(...skipping 558 matching lines...) Expand 10 before | Expand all | Expand 10 after
1543 visitor->trace(m_context); 1542 visitor->trace(m_context);
1544 visitor->trace(m_archive); 1543 visitor->trace(m_archive);
1545 visitor->trace(m_loaders); 1544 visitor->trace(m_loaders);
1546 visitor->trace(m_nonBlockingLoaders); 1545 visitor->trace(m_nonBlockingLoaders);
1547 visitor->trace(m_documentResources); 1546 visitor->trace(m_documentResources);
1548 visitor->trace(m_preloads); 1547 visitor->trace(m_preloads);
1549 visitor->trace(m_resourceTimingInfoMap); 1548 visitor->trace(m_resourceTimingInfoMap);
1550 } 1549 }
1551 1550
1552 } // namespace blink 1551 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698