third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp - Issue 2681233002: Actually handle the Vary header in blink, rather than punting on sight.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp

Issue 2681233002: Actually handle the Vary header in blink, rather than punting on sight. (Closed)

Patch Set: Remove whitespace handling and case sensitivity cases Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/loader/fetch/Resource.cpp ('k') | third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp

diff --git a/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp b/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp

index 5f21df77cecdece5778751731868621b2f203f17..9dc5030f25da3af35dd7c02cc825ec325cedfca5 100644

--- a/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp

+++ b/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp

@@ -970,8 +970,7 @@ ResourceFetcher::determineRevalidationPolicy(Resource::Type type,

existingResource == cachedResource(request.url()))

return Use;

- // Defer to the browser process cache for Vary header handling.

- if (existingResource->hasVaryHeader())

+ if (existingResource->mustReloadDueToVaryHeader(request))

return Reload;

// If any of the redirects in the chain to loading the resource were not