Refactor CSS Transitions to use CSSInterpolationTypes instead of AnimatableValues

Refactor CSS Transitions to use CSSInterpolationTypes instead of AnimatableValues

This patch updates CSSAnimations::calculateTransitionUpdateForProperty()
to use TransitionKeyframes instead of AnimatableValueKeyframes.
This obsoletes the use of AnimatableValues as the main data type for
CSS Transitions by replacing them with InterpolationValues and CSSInterpolationTypes.

Design doc:
https://docs.google.com/document/d/14tj6M5kyNpr10dFp5m43udOMUVPwxnulBEW7Kvh2vMs/edit?usp=sharing

BUG=681424
Review-Url: https://codereview.chromium.org/2680923005
Cr-Commit-Position: refs/heads/master@{#451598}
Committed: https://chromium.googlesource.com/chromium/src/+/6b6a6c64cdccdb95c20fa6c704cd44d5685f9be9

[alancutter (OOO until 2018), 2017-02-16 04:37:19]

Description was changed from

==========
[WIP] Use InterpolationTypes for CSS Transforms instead of AnimatableValues

BUG=681424
==========

to

==========
Refactor CSS Transitions to use CSSInterpolationTypes instead of
AnimatableValues

Design doc:


BUG=681424
==========

[alancutter (OOO until 2018), 2017-02-16 04:37:19]

alancutter@chromium.org changed reviewers:
+ suzyh@chromium.org

[alancutter (OOO until 2018), 2017-02-16 04:38:55]

Description was changed from

==========
Refactor CSS Transitions to use CSSInterpolationTypes instead of
AnimatableValues

Design doc:


BUG=681424
==========

to

==========
Refactor CSS Transitions to use CSSInterpolationTypes instead of
AnimatableValues

This patch updates CSSAnimations::calculateTransitionUpdateForProperty()
to use TransitionKeyframes instead of AnimatableValueKeyframes.

Design doc:
https://docs.google.com/document/d/14tj6M5kyNpr10dFp5m43udOMUVPwxnulBEW7Kvh2v...

BUG=681424
==========

[alancutter (OOO until 2018), 2017-02-16 04:45:26]

Description was changed from

==========
Refactor CSS Transitions to use CSSInterpolationTypes instead of
AnimatableValues

This patch updates CSSAnimations::calculateTransitionUpdateForProperty()
to use TransitionKeyframes instead of AnimatableValueKeyframes.

Design doc:
https://docs.google.com/document/d/14tj6M5kyNpr10dFp5m43udOMUVPwxnulBEW7Kvh2v...

BUG=681424
==========

to

==========
Refactor CSS Transitions to use CSSInterpolationTypes instead of
AnimatableValues

This patch updates CSSAnimations::calculateTransitionUpdateForProperty()
to use TransitionKeyframes instead of AnimatableValueKeyframes.
This obsoletes the use of AnimatableValues as the main data type for
CSS Transitions by replacing them with InterpolationValues and
CSSInterpolationTypes.

Design doc:
https://docs.google.com/document/d/14tj6M5kyNpr10dFp5m43udOMUVPwxnulBEW7Kvh2v...

BUG=681424
==========

[alancutter (OOO until 2018), 2017-02-16 04:58:19]

https://codereview.chromium.org/2680923005/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/animations/transition-zoomed-length.html
(left):

https://codereview.chromium.org/2680923005/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/transition-zoomed-length.html:6:
transition: 1s;
This test was broken. We can't have transitions enabled while we set up the
element's style or we'll trigger erroneous transitions.

I'm not sure why it was passing before but after the transitions refactor it was
properly broken. This patch includes a fix for it.

[suzyh_UTC10 (ex-contributor), 2017-02-17 00:34:19]

Yay! Thanks for getting this done. I want to give it another look over before
stamping, but definitely looking good.

https://codereview.chromium.org/2680923005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp (right):

https://codereview.chromium.org/2680923005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp:689: //
const_cast because we need to take a ref later when passing to
Comment obsolete?

[alancutter (OOO until 2018), 2017-02-17 00:54:57]

https://codereview.chromium.org/2680923005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp (right):

https://codereview.chromium.org/2680923005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp:689: //
const_cast because we need to take a ref later when passing to
On 2017/02/17 at 00:34:19, suzyh wrote:
> Comment obsolete?

Removed, thanks for catch.

[suzyh_UTC10 (ex-contributor), 2017-02-19 23:57:54]

lgtm

https://codereview.chromium.org/2680923005/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp (right):

https://codereview.chromium.org/2680923005/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp:654: for (const
auto& interpolationType : map.get(property)) {
(No change required)

I have a feeling that the pattern in this for-loop appears in a few places, but
cannot now find any instance other than InterpolationType::maybeConvertPairwise.
Is this something that might be able to become a util function?

https://codereview.chromium.org/2680923005/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp:676: // If we
have multiple transitions on the same property, we will use the
I don't understand this comment. Is it obsolete, or does it belong at a
different point in the code?

[alancutter (OOO until 2018), 2017-02-20 00:07:29]

https://codereview.chromium.org/2680923005/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp (right):

https://codereview.chromium.org/2680923005/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp:654: for (const
auto& interpolationType : map.get(property)) {
On 2017/02/19 at 23:57:54, suzyh wrote:
> (No change required)
> 
> I have a feeling that the pattern in this for-loop appears in a few places,
but cannot now find any instance other than
InterpolationType::maybeConvertPairwise. Is this something that might be able to
become a util function?

The structure is similar but there's differences in the details that make it not
suitable for having a helper function.

https://codereview.chromium.org/2680923005/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp:676: // If we
have multiple transitions on the same property, we will use the
On 2017/02/19 at 23:57:54, suzyh wrote:
> I don't understand this comment. Is it obsolete, or does it belong at a
different point in the code?

I suspect it's correct just in an odd location.

[alancutter (OOO until 2018), 2017-02-20 03:34:51]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 03:35:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 05:10:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 05:10:02]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[alancutter (OOO until 2018), 2017-02-20 06:34:46]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2017-02-20 06:34:46]

The patchset sent to the CQ was uploaded after l-g-t-m from suzyh@chromium.org
Link to the patchset: https://codereview.chromium.org/2680923005/#ps120001
(title: "Fix transition tests to not expect incorrect behaviour")

[commit-bot: I haz the power, 2017-02-20 06:34:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 08:35:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 08:35:27]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alancutter (OOO until 2018), 2017-02-20 10:39:17]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2017-02-20 10:39:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 11:34:12]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1487587157359020,
"parent_rev": "2090c9f72c7eebd76726965cfc7d15cb8d1cc12d", "commit_rev":
"6b6a6c64cdccdb95c20fa6c704cd44d5685f9be9"}

[commit-bot: I haz the power, 2017-02-20 11:34:46]

Description was changed from

==========
Refactor CSS Transitions to use CSSInterpolationTypes instead of
AnimatableValues

This patch updates CSSAnimations::calculateTransitionUpdateForProperty()
to use TransitionKeyframes instead of AnimatableValueKeyframes.
This obsoletes the use of AnimatableValues as the main data type for
CSS Transitions by replacing them with InterpolationValues and
CSSInterpolationTypes.

Design doc:
https://docs.google.com/document/d/14tj6M5kyNpr10dFp5m43udOMUVPwxnulBEW7Kvh2v...

BUG=681424
==========

to

==========
Refactor CSS Transitions to use CSSInterpolationTypes instead of
AnimatableValues

This patch updates CSSAnimations::calculateTransitionUpdateForProperty()
to use TransitionKeyframes instead of AnimatableValueKeyframes.
This obsoletes the use of AnimatableValues as the main data type for
CSS Transitions by replacing them with InterpolationValues and
CSSInterpolationTypes.

Design doc:
https://docs.google.com/document/d/14tj6M5kyNpr10dFp5m43udOMUVPwxnulBEW7Kvh2v...

BUG=681424

Review-Url: https://codereview.chromium.org/2680923005
Cr-Commit-Position: refs/heads/master@{#451598}
Committed:
https://chromium.googlesource.com/chromium/src/+/6b6a6c64cdccdb95c20fa6c704cd...
==========

[commit-bot: I haz the power, 2017-02-20 11:34:47]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/6b6a6c64cdccdb95c20fa6c704cd...