third_party/WebKit/LayoutTests/animations/transition-zoomed-length.html - Issue 2680923005: Refactor CSS Transitions to use CSSInterpolationTypes instead of AnimatableValues

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/animations/transition-zoomed-length.html

Issue 2680923005: Refactor CSS Transitions to use CSSInterpolationTypes instead of AnimatableValues (Closed)

Patch Set: cleanups Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/animations/interpolation/webkit-mask-box-image-source-interpolation-expected.txt ('k') | third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../resources/testharness.js"></script>	2 <script src="../resources/testharness.js"></script>

3 <script src="../resources/testharnessreport.js"></script>	3 <script src="../resources/testharnessreport.js"></script>

4 <style>	4 <style>

5 #target {	5 #target {

6 transition: 1s;
alancutter (OOO until 2018) 2017/02/16 04:58:18 This test was broken. We can't have transitions en This test was broken. We can't have transitions enabled while we set up the element's style or we'll trigger erroneous transitions. I'm not sure why it was passing before but after the transitions refactor it was properly broken. This patch includes a fix for it.
7 border-style: solid;	6 border-style: solid;

8 outline-style: solid;	7 outline-style: solid;

9 column-rule-style: solid;	8 column-rule-style: solid;

10 }	9 }

11 </style>	10 </style>

12 <div id="target"></div>	11 <div id="target"></div>

13 <script>	12 <script>

14 var lengthProperties = [	13 var lengthProperties = [

15 'baselineShift',	14 'baselineShift',

16 'borderBottomWidth',	15 'borderBottomWidth',

(...skipping 48 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
65 'y',	64 'y',

66 'lineHeight',	65 'lineHeight',

67 ];	66 ];

68 var expected = {};	67 var expected = {};

69	68

70 setup(() => {	69 setup(() => {

71 for (var property of lengthProperties) {	70 for (var property of lengthProperties) {

72 target.style[property] = '10px';	71 target.style[property] = '10px';

73 expected[property] = getComputedStyle(target)[property];	72 expected[property] = getComputedStyle(target)[property];

74 }	73 }

	74 target.style.transition = '1s';

75 internals.setZoomFactor(2);	75 internals.setZoomFactor(2);

76 });	76 });

77	77

78 for (var property of lengthProperties) {	78 for (var property of lengthProperties) {

79 test(() => {	79 test(() => {

80 assert_equals(getComputedStyle(target)[property], expected[property]);	80 assert_equals(getComputedStyle(target)[property], expected[property]);

81 }, 'Computed value of transitionable ' + property + ' should not change when z oom changes');	81 }, 'Computed value of transitionable ' + property + ' should not change when z oom changes');

82 }	82 }

83 </script>	83 </script>

OLD	NEW