Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h

Issue 2680923005: Refactor CSS Transitions to use CSSInterpolationTypes instead of AnimatableValues (Closed)
Patch Set: Fix transition tests to not expect incorrect behaviour Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h
diff --git a/third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h b/third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h
index 613f2e61582979cc6b1197bb97ce15cbadf5f02a..8b2de64d7103ad26023ebd037c66668dbfb27764 100644
--- a/third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h
+++ b/third_party/WebKit/Source/core/animation/css/CSSAnimationUpdate.h
@@ -163,15 +163,15 @@ class CSSAnimationUpdate final {
}
void startTransition(CSSPropertyID id,
- const AnimatableValue* from,
- const AnimatableValue* to,
+ RefPtr<AnimatableValue> from,
+ RefPtr<AnimatableValue> to,
PassRefPtr<AnimatableValue> reversingAdjustedStartValue,
double reversingShorteningFactor,
const InertEffect& effect) {
NewTransition newTransition;
newTransition.id = id;
- newTransition.from = from;
- newTransition.to = to;
+ newTransition.from = std::move(from);
+ newTransition.to = std::move(to);
newTransition.reversingAdjustedStartValue = reversingAdjustedStartValue;
newTransition.reversingShorteningFactor = reversingShorteningFactor;
newTransition.effect = &effect;
@@ -209,8 +209,8 @@ class CSSAnimationUpdate final {
DEFINE_INLINE_TRACE() { visitor->trace(effect); }
CSSPropertyID id;
- const AnimatableValue* from;
- const AnimatableValue* to;
+ RefPtr<AnimatableValue> from;
+ RefPtr<AnimatableValue> to;
RefPtr<AnimatableValue> reversingAdjustedStartValue;
double reversingShorteningFactor;
Member<const InertEffect> effect;

Powered by Google App Engine
This is Rietveld 408576698