third_party/WebKit/Source/core/animation/CompositorAnimations.cpp - Issue 2680923005: Refactor CSS Transitions to use CSSInterpolationTypes instead of AnimatableValues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CompositorAnimations.cpp

Issue 2680923005: Refactor CSS Transitions to use CSSInterpolationTypes instead of AnimatableValues (Closed)

Patch Set: Fix transition tests to not expect incorrect behaviour Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/animation/CompositorAnimations.cpp

diff --git a/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp b/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp

index e4524c769cdcaff03ad55521107a0244dc04a9cf..1a0909aedb4d57648757c06f1b0e0ef626746a9f 100644

--- a/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp

+++ b/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp

@@ -538,9 +538,8 @@ void addKeyframeToCurve(CompositorTransformAnimationCurve& curve,

}

template <typename PlatformAnimationCurveType>

-void addKeyframesToCurve(

- PlatformAnimationCurveType& curve,

- const AnimatableValuePropertySpecificKeyframeVector& keyframes) {

+void addKeyframesToCurve(PlatformAnimationCurveType& curve,

+ const PropertySpecificKeyframeVector& keyframes) {

auto* lastKeyframe = keyframes.back().get();

for (const auto& keyframe : keyframes) {

const TimingFunction* keyframeTimingFunction = 0;