Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2679783003: Deprecate FLAGS_quic_reloadable_flag_enable_async_get_proof (Closed)

Created:
3 years, 10 months ago by Fan Yang
Modified:
3 years, 10 months ago
Reviewers:
Ryan Hamilton, gredner
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate FLAGS_quic_reloadable_flag_enable_async_get_proof Merge internal change: 146243587 BUG=

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address gredner's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -403 lines) Patch
M net/quic/chromium/crypto/proof_source_chromium.h View 2 chunks +9 lines, -9 lines 0 comments Download
M net/quic/chromium/crypto/proof_source_chromium.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M net/quic/chromium/crypto/proof_test_chromium.cc View 1 2 chunks +27 lines, -42 lines 0 comments Download
M net/quic/core/crypto/proof_source.h View 2 chunks +5 lines, -27 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.h View 2 chunks +0 lines, -26 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_server_config.cc View 3 chunks +25 lines, -110 lines 0 comments Download
M net/quic/core/quic_crypto_client_stream_test.cc View 1 chunk +22 lines, -2 lines 0 comments Download
M net/quic/core/quic_crypto_server_stream.cc View 1 chunk +18 lines, -46 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/core/quic_server_session_base_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quartc/quartc_session.cc View 1 chunk +10 lines, -18 lines 0 comments Download
M net/quic/quartc/quartc_session_test.cc View 1 chunk +8 lines, -17 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 1 chunk +26 lines, -4 lines 0 comments Download
M net/quic/test_tools/failing_proof_source.h View 1 chunk +0 lines, -9 lines 0 comments Download
M net/quic/test_tools/failing_proof_source.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M net/quic/test_tools/fake_proof_source.h View 1 chunk +0 lines, -8 lines 0 comments Download
M net/quic/test_tools/fake_proof_source.cc View 3 chunks +8 lines, -30 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 4 chunks +27 lines, -35 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (9 generated)
Fan Yang
3 years, 10 months ago (2017-02-06 21:02:00 UTC) #4
gredner
LGTM modulo a request for a few comments. Thanks for taking care of this! Hopefully ...
3 years, 10 months ago (2017-02-06 21:07:54 UTC) #7
Fan Yang
On 2017/02/06 21:07:54, gredner wrote: > LGTM modulo a request for a few comments. Thanks ...
3 years, 10 months ago (2017-02-06 21:43:30 UTC) #9
gredner
lgtm
3 years, 10 months ago (2017-02-06 21:47:13 UTC) #11
gredner
lgtm
3 years, 10 months ago (2017-02-06 21:47:14 UTC) #12
Ryan Hamilton
3 years, 10 months ago (2017-02-06 23:15:17 UTC) #15
lgtm

Powered by Google App Engine
This is Rietveld 408576698