Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: net/quic/quartc/quartc_session.cc

Issue 2679783003: Deprecate FLAGS_quic_reloadable_flag_enable_async_get_proof (Closed)
Patch Set: Address gredner's comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_server_session_base_test.cc ('k') | net/quic/quartc/quartc_session_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quartc/quartc_session.cc
diff --git a/net/quic/quartc/quartc_session.cc b/net/quic/quartc/quartc_session.cc
index e31f72bb0dfafce1216e0fe4104a55dc55781057..3664d893f611980b6d8c397ea28adddf7a214b7a 100644
--- a/net/quic/quartc/quartc_session.cc
+++ b/net/quic/quartc/quartc_session.cc
@@ -28,30 +28,22 @@ class DummyProofSource : public net::ProofSource {
~DummyProofSource() override {}
// ProofSource override.
- bool GetProof(
- const net::QuicSocketAddress& server_addr,
- const std::string& hostname,
- const std::string& server_config,
- net::QuicVersion quic_version,
- base::StringPiece chlo_hash,
- const net::QuicTagVector& connection_options,
- net::QuicReferenceCountedPointer<net::ProofSource::Chain>* out_chain,
- net::QuicCryptoProof* proof) override {
- std::vector<std::string> certs;
- certs.push_back("Dummy cert");
- *out_chain = new ProofSource::Chain(certs);
- proof->signature = "Dummy signature";
- proof->leaf_cert_scts = "Dummy timestamp";
- return true;
- }
-
void GetProof(const net::QuicSocketAddress& server_addr,
const std::string& hostname,
const std::string& server_config,
net::QuicVersion quic_version,
base::StringPiece chlo_hash,
const net::QuicTagVector& connection_options,
- std::unique_ptr<Callback> callback) override {}
+ std::unique_ptr<Callback> callback) override {
+ net::QuicReferenceCountedPointer<net::ProofSource::Chain> chain;
+ net::QuicCryptoProof proof;
+ std::vector<std::string> certs;
+ certs.push_back("Dummy cert");
+ chain = new ProofSource::Chain(certs);
+ proof.signature = "Dummy signature";
+ proof.leaf_cert_scts = "Dummy timestamp";
+ callback->Run(true, chain, proof, nullptr /* details */);
+ }
};
// Used by QuicCryptoClientConfig to ignore the peer's credentials
« no previous file with comments | « net/quic/core/quic_server_session_base_test.cc ('k') | net/quic/quartc/quartc_session_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698