Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: net/quic/core/crypto/quic_crypto_server_config.h

Issue 2679783003: Deprecate FLAGS_quic_reloadable_flag_enable_async_get_proof (Closed)
Patch Set: Address gredner's comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/crypto/proof_source.h ('k') | net/quic/core/crypto/quic_crypto_server_config.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/crypto/quic_crypto_server_config.h
diff --git a/net/quic/core/crypto/quic_crypto_server_config.h b/net/quic/core/crypto/quic_crypto_server_config.h
index 42e9e2ed342eedde88375b54e5f20038c2805648..358f6afabb6503342a3c7173451d5bdb63197758 100644
--- a/net/quic/core/crypto/quic_crypto_server_config.h
+++ b/net/quic/core/crypto/quic_crypto_server_config.h
@@ -327,29 +327,6 @@ class QUIC_EXPORT_PRIVATE QuicCryptoServerConfig {
QuicByteCount chlo_packet_size,
std::unique_ptr<ProcessClientHelloResultCallback> done_cb) const;
- // BuildServerConfigUpdateMessage sets |out| to be a SCUP message containing
- // the current primary config, an up to date source-address token, and cert
- // chain and proof in the case of secure QUIC. Returns true if successfully
- // filled |out|.
- //
- // |cached_network_params| is optional, and can be nullptr.
- //
- // TODO(gredner): remove this when
- // FLAGS_quic_reloadable_flag_enable_async_get_proof is removed.
- bool BuildServerConfigUpdateMessage(
- QuicVersion version,
- base::StringPiece chlo_hash,
- const SourceAddressTokens& previous_source_address_tokens,
- const QuicSocketAddress& server_address,
- const QuicIpAddress& client_ip,
- const QuicClock* clock,
- QuicRandom* rand,
- QuicCompressedCertsCache* compressed_certs_cache,
- const QuicCryptoNegotiatedParameters& params,
- const CachedNetworkParameters* cached_network_params,
- const QuicTagVector& connection_options,
- CryptoHandshakeMessage* out) const;
-
// BuildServerConfigUpdateMessage invokes |cb| with a SCUP message containing
// the current primary config, an up to date source-address token, and cert
// chain and proof in the case of secure QUIC. Passes true to |cb| if the
@@ -357,9 +334,6 @@ class QUIC_EXPORT_PRIVATE QuicCryptoServerConfig {
// assumes ownership of |cb|.
//
// |cached_network_params| is optional, and can be nullptr.
- //
- // TODO(gredner): This method is an async version of the above. The
- // synchronous version will eventually be removed.
void BuildServerConfigUpdateMessage(
QuicVersion version,
base::StringPiece chlo_hash,
« no previous file with comments | « net/quic/core/crypto/proof_source.h ('k') | net/quic/core/crypto/quic_crypto_server_config.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698