Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: net/quic/chromium/crypto/proof_source_chromium.h

Issue 2679783003: Deprecate FLAGS_quic_reloadable_flag_enable_async_get_proof (Closed)
Patch Set: Address gredner's comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/chromium/crypto/proof_source_chromium.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/crypto/proof_source_chromium.h
diff --git a/net/quic/chromium/crypto/proof_source_chromium.h b/net/quic/chromium/crypto/proof_source_chromium.h
index 95b892d61f99ac6b61e16222cdf62afab1b5f6f2..f0a8c308f82e546126eda927c2d462c8ab1d8479 100644
--- a/net/quic/chromium/crypto/proof_source_chromium.h
+++ b/net/quic/chromium/crypto/proof_source_chromium.h
@@ -33,15 +33,6 @@ class NET_EXPORT_PRIVATE ProofSourceChromium : public ProofSource {
const base::FilePath& sct_path);
// ProofSource interface
- bool GetProof(const QuicSocketAddress& server_ip,
- const std::string& hostname,
- const std::string& server_config,
- QuicVersion quic_version,
- base::StringPiece chlo_hash,
- const QuicTagVector& connection_options,
- QuicReferenceCountedPointer<ProofSource::Chain>* out_chain,
- QuicCryptoProof* proof) override;
-
void GetProof(const QuicSocketAddress& server_ip,
const std::string& hostname,
const std::string& server_config,
@@ -51,6 +42,15 @@ class NET_EXPORT_PRIVATE ProofSourceChromium : public ProofSource {
std::unique_ptr<Callback> callback) override;
private:
+ bool GetProofInner(const QuicSocketAddress& server_ip,
+ const std::string& hostname,
+ const std::string& server_config,
+ QuicVersion quic_version,
+ base::StringPiece chlo_hash,
+ const QuicTagVector& connection_options,
+ QuicReferenceCountedPointer<ProofSource::Chain>* out_chain,
+ QuicCryptoProof* proof);
+
std::unique_ptr<crypto::RSAPrivateKey> private_key_;
QuicReferenceCountedPointer<ProofSource::Chain> chain_;
std::string signed_certificate_timestamp_;
« no previous file with comments | « no previous file | net/quic/chromium/crypto/proof_source_chromium.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698