Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: net/quic/quartc/quartc_session_test.cc

Issue 2679783003: Deprecate FLAGS_quic_reloadable_flag_enable_async_get_proof (Closed)
Patch Set: Address gredner's comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quartc/quartc_session.cc ('k') | net/quic/test_tools/crypto_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quartc/quartc_session_test.cc
diff --git a/net/quic/quartc/quartc_session_test.cc b/net/quic/quartc/quartc_session_test.cc
index fc19005789d29574cbc01fa2c697b926941ee338..884ff4503839ec8697a39307780496543754abe2 100644
--- a/net/quic/quartc/quartc_session_test.cc
+++ b/net/quic/quartc/quartc_session_test.cc
@@ -53,32 +53,23 @@ class FakeProofSource : public net::ProofSource {
explicit FakeProofSource(bool success) : success_(success) {}
// ProofSource override.
- bool GetProof(const QuicSocketAddress& server_ip,
+ void GetProof(const QuicSocketAddress& server_ip,
const std::string& hostname,
const std::string& server_config,
net::QuicVersion quic_version,
base::StringPiece chlo_hash,
const net::QuicTagVector& connection_options,
- QuicReferenceCountedPointer<net::ProofSource::Chain>* out_certs,
- net::QuicCryptoProof* proof) override {
+ std::unique_ptr<Callback> callback) override {
+ QuicReferenceCountedPointer<net::ProofSource::Chain> chain;
+ net::QuicCryptoProof proof;
if (success_) {
std::vector<std::string> certs;
certs.push_back("Required to establish handshake");
- *out_certs = new ProofSource::Chain(certs);
- proof->signature = "Signature";
- proof->leaf_cert_scts = "Time";
+ chain = new ProofSource::Chain(certs);
+ proof.signature = "Signature";
+ proof.leaf_cert_scts = "Time";
}
- return success_;
- }
-
- void GetProof(const QuicSocketAddress& server_ip,
- const std::string& hostname,
- const std::string& server_config,
- net::QuicVersion quic_version,
- base::StringPiece chlo_hash,
- const net::QuicTagVector& connection_options,
- std::unique_ptr<Callback> callback) override {
- LOG(INFO) << "GetProof() providing dummy credentials for insecure QUIC";
+ callback->Run(success_, chain, proof, nullptr /* details */);
}
private:
« no previous file with comments | « net/quic/quartc/quartc_session.cc ('k') | net/quic/test_tools/crypto_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698